Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds currently playing and copy URL commands. #40

Merged
merged 11 commits into from
Oct 17, 2021
Merged

Adds currently playing and copy URL commands. #40

merged 11 commits into from
Oct 17, 2021

Conversation

acristoffers
Copy link
Contributor

Adds two more commands to make this extension on pair with the script version: "Current Song" and "Copy Current Song's URL".

@acristoffers
Copy link
Contributor Author

On the second commit I copied the changes made to the VSCode Extension regarding linting into the Spotify Extension, and then made a small change to make Prettier work, so you can now run eslint --fix src/* and have formatting enforced. It seems to me that this is what was intended, but wasn't working for me.

@PitNikola PitNikola added the extension fix / improvement Label for PRs with extension's fix improvements label Oct 15, 2021
thomaspaulmann
thomaspaulmann reviewed Oct 15, 2021
View reviewed changes
extensions/spotify-controls/src/utils.ts Outdated
Comment on lines 18 to 28

/**
* Runs the AppleScript
*
* @param appleScript - The AppleScript to run
* @throws An error when the AppleScript fails to run
* @returns A promise that is resolved when the AppleScript finished running
*/
export async function runAppleScriptAndReturn(appleScript: string) {
return await runAppleScript(appleScript);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need this? Seems like the function doesn't add anything on top of the runAppleScript one. How about keeping it simple and remove runAppleScriptAndReturn and use runAppleScript directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the style I saw without thinking about it. It makes sense to just use the function directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make this change as well and use the function directly before I merge the PR? Please re-request a review afterwards.

thomaspaulmann
thomaspaulmann requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@thomaspaulmann thomaspaulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding these commands. I left a few inline comments to make the toast fit our UI guidelines. Also, I reverted some bits of your commit for formatting. Since the extension doesn't use any React, we can get of these deps.

This reminds me that we should add a lint script. Then you can run npm run lint to do all the magic.

acristoffers and others added 4 commits October 16, 2021 10:05
@acristoffers @thomaspaulmann
Corrects Toast call.
2af64ca 
Co-authored-by: Thomas Paul Mann <[email protected]>
@acristoffers @thomaspaulmann
Corrects Toast call.
0335898 
Co-authored-by: Thomas Paul Mann <[email protected]>
@acristoffers @thomaspaulmann
Corrects Toast call.
ed685fa 
Co-authored-by: Thomas Paul Mann <[email protected]>
@acristoffers @thomaspaulmann
Corrects Toast call.
b89b24b 
Co-authored-by: Thomas Paul Mann <[email protected]>
thomaspaulmann
thomaspaulmann requested changes Oct 16, 2021
View reviewed changes
extensions/spotify-controls/src/utils.ts Outdated
Comment on lines 18 to 28

/**
* Runs the AppleScript
*
* @param appleScript - The AppleScript to run
* @throws An error when the AppleScript fails to run
* @returns A promise that is resolved when the AppleScript finished running
*/
export async function runAppleScriptAndReturn(appleScript: string) {
return await runAppleScript(appleScript);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make this change as well and use the function directly before I merge the PR? Please re-request a review afterwards.

@acristoffers
Copy link
Contributor Author

Yes, I'm going to do it today.

thomaspaulmann
thomaspaulmann reviewed Oct 17, 2021
View reviewed changes
extensions/spotify-controls/package.json
"name": "copyUrl",
"title": "Copy Current Song's URL",
"subtitle": "Spotify",
"description": "Currently playing song's URL in Spotify.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Currently playing song's URL in Spotify.",
"description": "Currently playing track's URL in Spotify.",

thomaspaulmann
thomaspaulmann approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@thomaspaulmann thomaspaulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I changed song to track to fit the other commands.

@thomaspaulmann thomaspaulmann merged commit d575da6 into raycast:main Oct 17, 2021
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
@acristoffers @FezVrasta
Adds currently playing and copy URL commands. (raycast#40)
4c38664
thuoe added a commit to thuoe/raycast-extensions that referenced this pull request Jan 18, 2024
@thuoe
fix: error handle fetch league hook (raycast#40)
7a45af9
raycastbot added a commit that referenced this pull request Jan 21, 2024
@thuoe @raycastbot @pernielsentikaer
Update footy-report extension (#10183)
3a8ef7d 
* Add footy-report extension

- Merge pull request #22 from thuoe/next
- Merge pull request #21 from thuoe/docs/2023-12-26-changelog
- docs: update changelog
- Merge pull request #20 from thuoe/feature/thu-33-redesign-test-api-command
- docs: update screenshots
- chore: delete unused assets
- feat: action to open ext preferences
- feat: use form to test API access token
- Merge pull request #19 from thuoe/bugfix/fetch-teams
- fix: optional position name
- Merge pull request #2 from thuoe/feature/thu-15-raycast-create-search-command
- Merge pull request #10 from thuoe/feature/thu-26-create-command-screenshots
- docs: include command screenshots in README.md
- docs: player stats screenshot
- docs: team list screenshot
- docs: update team details & API screenshots
- docs: delete outdated screenshots
- docs: create command screenshots
- Merge pull request #17 from thuoe/bugfix/type-errors
- build: include build step during CI pipeline
- fix: type error fetch teams hook
- fix: type error command arg
- fix: type errors for fetching fixtures
- fix: type erros from player stats
- fix: 2d array type further improvements
- fix: array type
- fix: multidimensional array type
- Merge pull request #18 from thuoe/feature/unit-tests
- build: test step to ci job
- test: create markdown from 2d array
- test: grouping obj
- test: format & select fields
- build: install jest
- Merge pull request #16 from thuoe/feature/thu-32-search-command-create-readme
- docs: add missing command subheading
- docs: create README.md template
- Merge pull request #15 from thuoe/feature/thu-29-player-markdown-season-stats
- feat: include yellow/red card stats
- refactor: set/filter events
- fix: map player id
- feat: fetch player stats across seasons for teams
- feat: create markdown table function
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #14 from thuoe/chore/gh-actions-ci
- build: provide extension description
- refactor: ci pipeline
- Merge remote-tracking branch \'origin/next\' into feature/thu-15-raycast-create-search-command
- Merge pull request #13 from thuoe/feature/thu-28-create-extension-icon
- feat: create extension icon
- feat: create argument to search by team name
- feat: group squad by positions in grid view
- feat: create grouping function
- feat: create simple grid view for squad players
- feat: map tvstations to fixture calendar events
- feat: provide calendar name preference
- feat: wrap action in confirmation alert
- feat: create calendar event action for upcoming fixtures
- feat: icon for player details action button
- feat: introduce limit across fixture list items
- feat: populate upcoming fixtures list section
- fix: correct time range when fetching fixtures
- fix: rename fixture list category
- refactor: format fixture timestamp during response mapping
- feat: fetch latest fixtures and populate list items
- fix: correct squad subtitle count
- fix: populate title & placeholder with team name
- refactor: generic function to compute select fields
- fix: maximise player image size in markdown
- feat: create player details view
- feat: map player dob
- feat: restructure search command to search, favorite & display teams details
- feat: create new view for team details using dummy data
- build: create alias for shared types
- feat: create hook to fetch team with player info
- fix: invoke custom hook after change to path & provide execute flag
- refactor: rename search team command
- fix: prevent persisting dropdown value
- feat: create dropdown with team sections using dummy data
- feat(command): create search command template
- Merge pull request #12 from thuoe/chore/env-var-gh-actions
- chore: default env vars for gh actions
- chore: create basic ci pipeline (#11)
- Merge pull request #6 from thuoe/chore/local-dev-improvements
- fix: add missing package
- chore: format remaining files
- chore: update editorconfig
- chore: format code on save
- chore: create editorconfig file
- Merge pull request #5 from thuoe/feature/thu-23-create-preferences
- refactor: remove optional chaining
- refactor: create custom hook for API call
- feat: test API command
- chore: provide ESLint config (#4)
- Merge pull request #1 from thuoe/feature/thu-14-create-project-template
- feat: create simple command template
- Initial commit

* Update footy-report extension

- Merge pull request #26 from thuoe/next
- Merge pull request #25 from thuoe/bugfix/squad-details
- fix: map fixture id to item key
- fix: increase limit of squad players rendered in grid
- chore: remove console log
- fix: display age && render if dob provided
- fix: show seasons based on relevant team
- fix: filter season stats if no details found
- fix: render players without shirt no
- Merge pull request #23 from thuoe/main

* Update footy-report extension

- Merge pull request #29 from thuoe/next
- Merge pull request #28 from thuoe/feature/thu-34-error-handling-faulty-api-tokens
- fix: handle errors across views
- refactor: hooks response types
- fix: handle hook data responses if invalid token is found
- fix: provide error from promise hook
- feat: create error toast hook
- Merge pull request #27 from thuoe/main

* Update footy-report extension

- Merge pull request #32 from thuoe/next
- Merge pull request #31 from thuoe/feature/thu-35-api-test-command-validate-sportmonks-endpoint
- feat: validate endpoint before submit
- Merge pull request #30 from thuoe/main

* Update CHANGELOG.md and optimise images

* Update footy-report extension

- Merge pull request #37 from thuoe/next
- Merge pull request #36 from thuoe/chore/sync-raycast-repo
- Merge branch \'contributions/merge-1705420963700882000\' into chore/sync-raycast-repo
- Pull contributions
- Merge pull request #35 from thuoe/next
- Merge pull request #24 from thuoe/feature/thu-18-raycast-command-search-league-standings
- docs: update timestamp
- fix: filter only domestic leagues
- Merge remote-tracking branch \'origin/next\' into feature/thu-18-raycast-command-search-league-standings
- docs: include install button (#34)
- Merge pull request #33 from thuoe/main
- Merge remote-tracking branch \'origin/next\' into feature/thu-18-raycast-command-search-league-standings
- docs: update changelog
- feat: action to open team details from standing
- docs: include command screenshot
- feat: include search bar placeholder
- fix: map league id
- feat: display standing once league is selected
- feat: map recent form for each standing
- fix: map image path
- feat: map matches played
- feat: create hook to fetch league standing data
- fix: map active season
- feat: fetch leagues

* Already an install button 🙂

* fix: error handle invalid api tokens for fetching standings (#38)

* fix: linting issues (#39)

* fix: error handle fetch league hook (#40)

* Update README.md

* Update CHANGELOG.md and optimise images

---------

Co-authored-by: raycastbot <[email protected]>
Co-authored-by: Per Nielsen Tikær <[email protected]>
Parajulibkrm added a commit to Parajulibkrm/raycast-extensions that referenced this pull request Nov 9, 2024
@Parajulibkrm
Add miti-raycast extension
58928cd 
- initial features
- Merge pull request raycast#103 from axyut/port-to-oslo
- fix: expire session conditional
- feat: completely removed lucia-auth dependency
- minor changes
- fix: 🐛 no day selection on !isSameMonth
- feat: ✨ internal package for query
- feat: ✨ types package
- fix: minor
- refactor
- deps: change nepali date package
- backend: auth, google calendar integration
- Basic UI components
- minor fixes
- Added raycast initial
- feat: ✨ Migrated to v51 for expo
- initial commit
- added gitignore
- ignore turbo
- Added gitignores
- cleanup
- feat: ✨ Added announcement
- typo
- fix: 💄 view all events button not spanning full width
- chore: bump date package version
- fix: set fixed height of day cells
- Merge pull request raycast#64 from nabinkdl/main
- Update About.tsx
- Merge pull request raycast#60 from pandeysubash404/event-display
- Merge pull request raycast#61 from yuvrajdahal/main
- Merge pull request raycast#63 from PoskOfficial/fix/issue62
- fix: 🐛 app crashing on switching months
- Synchorization issue with previous code
- English date converter crashing fixed
- English date converter crashing fixed
- fix: 🚑 Update user logic on signin bug fix
- Updated to display today\'s date
- fix: 🐛 Update db information on sign in
- Merge pull request raycast#59 from pandeysubash404/event-display
- chore: 🐛 Fixed Positioning of Relative Date on Homepage
- chore: ♻️ Made the event string logic declarative
- conveys the logic in a more declarative manner
- adjustments to the relativeTimeFromElapsed function
- fixed event issue and hide user data from console
- Fixed the issue related event display
- Merge pull request raycast#57 from pandeysubash404/fix-date-issue
- chore: ➖ Removed Jest Dev Dependency
- Removed package-lock.json and added pnpm-lock.yaml as requested
- Remove pnpm dependency as requested by repository owner
- Fix date issue in input field
- Changed readme
- Create LICENSE
- Updated type definitions
- Merge pull request raycast#52 from nabin-kandel/main
- Merge branch \'PoskOfficial:main\' into main
- chore: ✨ updated screenshots
- ScreenShot Updated
- Merge pull request raycast#50 from PoskOfficial/develop
- fix: 🐛 page reloading in mobile view
- Merge pull request raycast#49 from nabin-kandel/main
- Added Open graph Description
- Update Readme.md
- Added og image
- Merge pull request raycast#48 from nabin-kandel/main
- Added banner image
- Merge pull request raycast#47 from PoskOfficial/fix_create_event_date
- style: 💄 changed footer border color
- fix: 🐛 event end and start date off by 1
- Added missing lock files
- Added missing lock files
- Merge pull request raycast#46 from PoskOfficial/develop
- chore: ✏️ updated translation values
- chore: ⚰️ removed unused translations
- feat: ✨ added footer
- moved imports
- Deleted large file
- Added update logic
- chore: 🚧 Added new SW
- Merge pull request raycast#45 from PoskOfficial/datepicker_fix
- style: 💄 fixed spinner\'s wrong positioning
- fix: 🐛 month date picker value offset by -1
- fix: 🐛 corrected photo url
- fix: 🐛 Fixed User Query issue
- fix: 🐛
- feat: 🐛 Added offline support to react query
- Added calendar picker to event creation modal
- fix: 🐛 Fixed width issues in homepage
- Removed unused param
- Made time field required
- fix: 🐛 Removed unnecessary console logs
- fix: 🐛 Fixed some UI Bugs
- Added missing adhik to english translation of chandrama
- fix: ⚰️ Removed redundant code
- fix: 🐛 Fixed Spinner Size
- perf: ⚡ Refactored for performance and readability
- Merge pull request raycast#43 from PoskOfficial/dark_mode
- style: 💄 added dark mode to the event dialogue
- feat: ✨ Added Analytics to install btn
- feat: ✨ added access role to events
- feat: ✨ Added endpoint to get calendar list
- Merge pull request raycast#42 from PoskOfficial/dark_mode
- fix: 💚 fixed build removing unused imports
- Merge branch \'main\' into dark_mode
- feat: ✨ added styles for dark mode
- feat: ✨ Added support for multiple calendars on backend
- feat: ✨ Added Analytics
- Merge pull request raycast#41 from PoskOfficial/nischal
- Merge branch \'nischal\' of https://github.com/PoskOfficial/Nepali-calendar-web into nischal
- fix: 🐛 fixed minor bug during language translation in dropdown
- fix language issue
- Merge remote-tracking branch \'origin/main\' into
- changes in translation files
- js to ts file
- Removed unused files
- Merge remote-tracking branch \'origin/main\' into nischal
- feat: ✨ Stored Dark Mode setting in local storage
- spinner in upcoming events page
- hide language change buttons
- feat: 🚧 added date difference string to single upcoming event, and setup language translation for date converter page
- Fixed ts issues in i18next
- Fixed Hamburger color
- Added Dark Mode Strategy to tailwind
- Refactored
- Bug fixes
- Added contact details in about page
- feat: ✨ Added credits in About Page
- bug fixes
- docs: 📝 Changed translation of Home
- fix: 🐛 Fixed Crash on clear
- Merge pull request raycast#40 from PoskOfficial/user_settings_disclosure
- refactor: ♻️ used higher quality icon for sign in with google
- refactor: ♻️ used sign in with google icon instead of text
- feat: ✨ added a disclosure to switch languages
- Added missing lock file
- Merge branch \'main\' of https://github.com/PoskOfficial/Nepali-calendar-web
- Added about page
- fix: ✨ Increased cookie life
- Merge pull request raycast#39 from PoskOfficial/nischal
- refactor: 🚚 moved useLanguage to helper and renamed useUser
- fix: 💚 removed unused imports, changed useLangauge name
- Merge remote-tracking branch \'origin/main\' into nischal
- feat: 🚧 added uselangauge hook,
- calendar date , reminder text and upcoming
- Merge pull request raycast#38 from poudelsanchit/main
- Merge branch \'main\' into pr/poudelsanchit/38
- Fix some linting errors
- fix: 🐛 Fixed no update on logout
- feat: ✨ Added Install Toaster Popup
- feat: ✨ Add PWA Install Button
- Added app shortcuts
- feat: ✨ Added Screenshots on install screen
- feat: 🐛 Added support for offline first in react query
- feat: ✨ DateConverter
- feat: ✨ Cached api response
- fix: 🐛 Fixed No event fetched on month change
- Bug fixes
- Merge pull request raycast#37 from PoskOfficial/add_react_query
- fix: 🩹 checked for loading state for rendering events list
- fix: ⚰️ removed unused imports
- Merge branch \'main\' into add_react_query
- fix: 🐛 off by 1 error in chandrama
- feat: ✨ added react query
- Added new logo
- feat: 🚧 progressed with the feature
- docs: 📝 Added Fork and setup instructions
- feat: 🚧 language translation
- Merge pull request raycast#36 from PoskOfficial/feat_nepali_date_picker
- Merge branch \'main\' into feat_nepali_date_picker
- fix: 🐛 next month to the selection being selected
- Merge branch \'feat_nepali_date_picker\' of github.com:PoskOfficial/Nepali-calendar-web into feat_nepali_date_picker
- fix: 🐛 end and start time, timezone error
- added node modules to gitignore
- Merge pull request raycast#35 from PoskOfficial/nischal
- Merge branch \'main\' into nischal
- added gitignore
- chore: Added single command to install both frontend and backend
- feat: ✨ added nepali date picker
- feat: ✨ added a popup modal for each reminder
- popup modal for single event
- Merge pull request raycast#34 from PoskOfficial/google_cal_compatible
- refactor: ♻️ made start and end date logic declarative
- fix: 🐛 multi day all day events not showing up
- Merge remote-tracking branch \'origin/main\' into nischal
- feat: 🚧 events popup
- feat: ✨ event date time compatible with google calendar
- feat: ✨ Added Delete Event Route
- feat: ✨ Added event background sync
- Merge pull request raycast#14 from PoskOfficial/nischal
- fixes in calendar.tsx
- feat: ✨ Added event color dot
- Added Event Creation and List
- feat: ✨ Fetched Event List from backend
- Added build step to docs
- docs: 📝 Added Readme
- added lib to gitignore
- feat: 🌱 Added missing files
- Added deta space configuration
- Merge branch \'main\' of https://github.com/Parajulibkrm/calendar-backend
- moved to backend folder
- moved files to frontend/
- feat: ✨ Added Google Authentication
- feat: ✨ Added Privacy Policy
- Merge pull request raycast#13 from nirajacharyaa/main
- Merge branch \'main\' into main
- fix: 🐛 Escaped APi Route from Client side cache
- feat: ✨ Changed hashrouter to browserrouter
- Fixed auth links cache issue
- fix: 🐛 upcoming events and minor styles
- Added Sign In
- Styling bug fixes
- Added a navbar
- Merge pull request raycast#12 from nirajacharyaa/view-added-events
- fix: 💚 build fix
- feat: ✨ user events modal and view events
- added .env to giitignore
- initial commit
- refactor: 🔥 Removed image for floating action button
- Merge pull request raycast#11 from PoskOfficial/popupmodal
- Reminder popup modal for indivdual day
- Merge branch \'main\' of https://github.com/PoskOfficial/Nepali-calendar-web
- added reminder popup
- feat: 🐛 fixed off by one error
- feat: ✨ Added upcoming events page. credit: @headshigh
- feat: ✨ Added Multiple Event List for each day
- Merge pull request raycast#10 from PoskOfficial/pwa-setup
- chore: 🐛 Fixed PWA issue
- chore: ✨ Added PWA configuration
- Merge pull request raycast#8 from nirajacharyaa/load_calendar_data
- fix: 🐛 Bug Fixes
- fix: minor changes
- Update issue templates
- Update issue templates
- Revert "Merge branch \'main\' into load_calendar_data"
- Merge branch \'main\' into load_calendar_data
- fix: events dots
- minor fixes
- Bug fixes
- fix: 🐛 Fixed off by one error
- memoized
- set selected day to today
- Merge pull request raycast#7 from PoskOfficial/nischal
- ts error fix
- lockfileversion
- improvements
- chore: loaded calendar data
- upcoming events page incomplete
- Merge branch \'main\' of https://github.com/PoskOfficial/Nepali-calendar-web
- chore: 🍱 Added Calendar Files
- Update issue templates
- fixed type warnings
- chore: 🎉 Initial Commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspaulmann thomaspaulmann thomaspaulmann approved these changes

Assignees
No one assigned
Labels
extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acristoffers @thomaspaulmann @PitNikola