Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add worktrees extension #6867

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Add worktrees extension #6867

merged 8 commits into from
Jul 7, 2023

Conversation

canac
Copy link
Contributor

@canac canac commented May 31, 2023 •
edited
Loading

Description

New extension to view, add, and remove git worktrees.

Screencast

Screen.Recording.2023-05-30.at.8.18.38.PM.mov

Checklist

@canac
Add worktrees extension
730cf42 
- Make starting branch configurable
- Prepare for publish
- Update eslint config
- Move hook to component
- Add command to create new worktree
- Only replace ~/
- Document unnecessary eslint-disable
- Make terminal and editor configurable
- Use fd when possible
- Display error message
- Add confirmation toast
- Ignore the main worktree
- Parse porcelain format
- Raycast extension for managing git worktrees
- Update dependencies
- Migrate to latest
- Fix package name
- Remove superjson dependency
- Fix useEffect dependencies
- Merge pull request raycast#10 from canac/dependabot/npm_and_yarn/journal/electron-and-react-devtools-23.2.4
- Merge pull request raycast#9 from canac/dependabot/npm_and_yarn/bible/electron-and-react-devtools-23.2.4
- Bump electron and react-devtools in /journal
- Bump electron and react-devtools in /bible
- Merge pull request raycast#8 from canac/dependabot/npm_and_yarn/bible/node-fetch-3.2.10
- Merge pull request raycast#6 from canac/dependabot/npm_and_yarn/bible/http-cache-semantics-4.1.1
- Merge pull request raycast#7 from canac/dependabot/npm_and_yarn/bible/ansi-regex-3.0.1
- Merge pull request raycast#5 from canac/dependabot/npm_and_yarn/bible/minimist-1.2.8
- Bump node-fetch from 3.2.0 to 3.2.10 in /bible
- Bump ansi-regex from 3.0.0 to 3.0.1 in /bible
- Bump http-cache-semantics from 4.1.0 to 4.1.1 in /bible
- Bump minimist from 1.2.5 to 1.2.8 in /bible
- Add BibleGateway scraper
- Improve journal extension metadata
- Run prettier
- Merge pull request raycast#4 from canac/dependabot/npm_and_yarn/journal/minimatch-3.1.2
- Bump minimatch from 3.0.4 to 3.1.2 in /journal
- Merge pull request raycast#3 from canac/dependabot/npm_and_yarn/journal/http-cache-semantics-4.1.1
- Bump http-cache-semantics from 4.1.0 to 4.1.1 in /journal
- Merge pull request raycast#2 from canac/dependabot/npm_and_yarn/journal/ansi-regex-3.0.1
- Bump ansi-regex from 3.0.0 to 3.0.1 in /journal
- Merge pull request raycast#1 from canac/dependabot/npm_and_yarn/journal/minimist-1.2.6
- Bump minimist from 1.2.5 to 1.2.6 in /journal
- Keep Raycast open after choosing a tag
- Clear the tag search after choosing a tag
- Journal Raycast extension
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label May 31, 2023
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

pernielsentikaer
pernielsentikaer requested changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment •
edited by sxn
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

  • When I try to submit the form without entering anything there is no feedback, even a simple toast could help (or the error when you hover/blur the New Branch Name field

Maybe you could use useForm for that form

worktrees 2023-06-05 at 13 31 56 worktrees 2023-06-05 at 13 33 43

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-assigned this Jun 5, 2023
@canac
Update worktrees extension
c2d47c6 
- Merge branch 'contributions/merge-1686342399257255000'
- Pull contributions
- Refactor to use useForm
@canac canac requested a review from pernielsentikaer June 9, 2023 20:27
@canac
Copy link
Contributor Author

canac commented Jun 9, 2023

Thanks for the feedback @pernielsentikaer! I refactored to use useForm like you suggested. I ran into what I believe is a bug in the API that is currently preventing my form from being quite as polished as it could be: #7016.

@pernielsentikaer
Copy link
Collaborator

You're right! Thanks for flagging the bug, it should be fixed in the next release 🙂

@canac
Copy link
Contributor Author

canac commented Jun 22, 2023

@pernielsentikaer Now that that bug fix has been released, this is ready for another review pass.

@thomaslombart thomaslombart self-assigned this Jul 4, 2023
thomaslombart
thomaslombart requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed there's no README.md or CHANGELOG.md. Is that intentional? Could you add them?

@canac
Copy link
Contributor Author

canac commented Jul 7, 2023

@thomaslombart Sorry, I added a changelog now. This section in the docs seems to say that a README.md is only necessary in advanced configuration is necessary or has a non-trivial use case, which I don't believe applies to my extension. I don't think there would be much meaningful information to add to a readme. Let me know if I you think I actually do need one to merge.

@canac canac requested a review from thomaslombart July 7, 2023 01:29
thomaslombart
thomaslombart approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@thomaslombart thomaslombart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's ship this extension 🚀

@thomaslombart thomaslombart merged commit bcbb02e into raycast:main Jul 7, 2023
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/canac/worktrees

@canac canac deleted the ext/worktrees branch July 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslombart thomaslombart thomaslombart approved these changes

@pernielsentikaer pernielsentikaer Awaiting requested review from pernielsentikaer

Assignees

@thomaslombart thomaslombart

@pernielsentikaer pernielsentikaer

Labels
new extension Label for PRs with new extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canac @raycastbot @pernielsentikaer @thomaslombart