Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [Deepcast]: add commands to translate selected test into every possible language #947

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

mooxl
Copy link
Contributor

@mooxl mooxl commented Feb 19, 2022

Description

This PR adds commands to my extension which allows faster translation into the desired target language.

Screencast

Screen.Recording.2022-02-19.at.15.37.12.video-converter.com.mp4

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension labels Feb 19, 2022
@mooxl mooxl mentioned this pull request Feb 19, 2022
3 tasks
@mooxl
Copy link
Contributor Author

mooxl commented Feb 19, 2022

Hey!
Is there any way I can add parameters to the entry point file in the manifest?
If yes, one could save the redundancy with the 'one file for each language'.

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mooxl 👋

Thanks for your contribution, what I miss is a README (so I know how to get an API Key)

And for now it's not possible to pass arguments, but you can follow this issue #59 😄

Two comments:

  • The word “into” should be “Into” in all commands
  • Do you have time to make a simple README?

Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.

Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
@mooxl
Copy link
Contributor Author

mooxl commented Feb 25, 2022

Hey @pernielsentikaer,

And for now it's not possible to pass arguments, but you can follow this issue #59 😄

Ahh cool! Is there an ETA for this issue?

I hope the added README is enough for the first pass.

@pernielsentikaer
Copy link
Collaborator

Unfortunately, there is no ETA for this yet, but it's popping up quite often at the moment 😄

One last thing I reccommend is to add "selected" to description, so it's like "Translate selected text into Chinese using DeepL" so the user is aware of how it actually works :)

When this is corrected, then I can't find anything else 😄 💪

@mooxl
Copy link
Contributor Author

mooxl commented Feb 28, 2022

Ahh okay, let's hope that this issue will be resolved soon. Then you could save all the different files for each command. 😍
I just ran the CI again, but unfortunately I still get an error. Can you help me with this? @pernielsentikaer

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mooxl 👋

Thanks for your update! Yes, we do have some issue with the linter at the moment, I got top men on the job to resolve it! :)

@sxn
Copy link
Contributor

sxn commented Mar 1, 2022

🎉

@sxn sxn merged commit 2be94c1 into raycast:main Mar 1, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/mooxl/deepcast

@mooxl mooxl deleted the add-translate-to-german-command branch March 7, 2022 09:40
@t6adev t6adev mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants