-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat [Deepcast]: add commands to translate selected test into every possible language #947
Conversation
Signed-off-by: Max Schmidt <[email protected]>
Hey! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mooxl 👋
Thanks for your contribution, what I miss is a README (so I know how to get an API Key)
And for now it's not possible to pass arguments, but you can follow this issue #59 😄
Two comments:
- The word “into” should be “Into” in all commands
- Do you have time to make a simple README?
Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions.
Signed-off-by: Max Schmidt <[email protected]>
Signed-off-by: Max Schmidt <[email protected]>
Hey @pernielsentikaer,
Ahh cool! Is there an ETA for this issue? I hope the added README is enough for the first pass. |
Unfortunately, there is no ETA for this yet, but it's popping up quite often at the moment 😄 One last thing I reccommend is to add "selected" to description, so it's like "Translate selected text into Chinese using DeepL" so the user is aware of how it actually works :) When this is corrected, then I can't find anything else 😄 💪 |
Signed-off-by: Max Schmidt <[email protected]>
Ahh okay, let's hope that this issue will be resolved soon. Then you could save all the different files for each command. 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 |
Published to the Raycast Store: |
Description
This PR adds commands to my extension which allows faster translation into the desired target language.
Screencast
Screen.Recording.2022-02-19.at.15.37.12.video-converter.com.mp4
Checklist
npm run build
and tested this distribution build in Raycast