Use mingw32-make in build-MinGW-W64.bat #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all mingw-w64 toolchains on windows are guaranteed to have make, but virtually all of them have mingw32-make. MSYS2 UCRT does not provide make, but does provide mingw32-make. So users who have added UCRT to the PATH (Not advisable!) but not msys64 will have errors about a missing make. VSCode's tasks.json uses mingw32-make anyway, so it's better to stay consistent with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all mingw-w64 toolchains on windows are guaranteed to have make, but virtually all of them have mingw32-make. MSYS2 UCRT does not provide make, but does provide mingw32-make. So users who have added UCRT to the PATH (Not advisable!) but not msys64 will have errors about a missing make.
VSCode's tasks.json uses mingw32-make anyway, so it's better to stay consistent with it.