Skip to content
This repository has been archived by the owner on Aug 16, 2019. It is now read-only.

Commit

Permalink
Keep exec folders in the repo to help supervisor
Browse files Browse the repository at this point in the history
Supervisor will fail if required directories do not exist. This can be
rather inconvenient, as we `overwatchDeploy` runs too late to create
them. To avoid this issue, we keep the directories in the repository, so
they'll always exist (assuming execution is started in the Overwatch
root directory, which is usually the case).
  • Loading branch information
raymondEhlers committed Oct 18, 2018
1 parent e207c10 commit ec64fbd
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ Since we use supervisor, we use that to handle the logs. Then, we need to select
Although it appears that it would be convenient to put them in the `dataFolder` directory, this is problematic
because they will be accessible through the `webApp`. Instead, we put them in the `exec` directory, which is a
directory dedicated to files generated during execution. It may also contain configuration files, etc.

Note that we explicitly keep empty `logs`, `config` and `sockets` directories inside of the `exec` directory
in the git repository to ensure that supervisor doesn't fail to execute due missing those directories. It is
not required to use the directories in the repository, but it certainly is convenient.
5 changes: 5 additions & 0 deletions exec/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# We want to ignore everything in these directories
logs/
nginx/
config/
sockets/
Empty file added exec/config/.keepInGit
Empty file.
Empty file added exec/logs/.keepInGit
Empty file.
Empty file added exec/sockets/.keepInGit
Empty file.

0 comments on commit ec64fbd

Please sign in to comment.