Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out validation of arguments for create_entry #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bonehead06
Copy link

This change was made to make it easier to understand which argument did not validate. Make the 'create_entry' and 'create_group' methods returned the created object for easier manipulation and re-use of the created object

…anding of which argument did not validate. Make the 'create_entry' and 'create_group' methods returned the created object for easier manipulation and re-use of the created object
@bonehead06
Copy link
Author

This PR actually has 3 parts.

  1. Break out the validation of arguments for create_entry so I could debug what I was doing wrong
  2. Return the created group from the create_group method
  3. Return the created entry from the create_entry method.
    Would you like these split into multiple PRs or is it OK to leave all of these as one?

Cheers,

Keith (aka bonehead06)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant