use GetWindowScaleDPI to calculate size for rlReadScreenPixels in sceenshot/recording #2446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS when running on a display with retina resolution or on an external 4k screen, the
TakeScreenshot
function triggered by F12 and the gif recording triggered by Ctrl-F12 ignore the scaling so they only grab the lower left quarter of the window.This change uses the factors from
GetWindowScaleDPI()
to scale width and height to allow the full window content to be grabbed even if scaling is active.Not sure if there would be need for a check of
FLAG_WINDOW_HIGHDPI
, from my understanding, the scaling would be needed there to, for other cases if should be a scaling by 1, and the overhead ofGetWindowScaleDPI()
seems small compared to the gif or png encoding that happens afterwards.