Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update subscription flow and update plugins #145

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Nov 4, 2022

related PRs raystack/proton#216 and raystack/salt#61

Changes

  • Update create alerts to be more generic
  • Simplify plugins
  • Update subscription flow (remove transaction from subscription, sync config when adding namespace instead)
  • Add end-to-end tests

@mabdh mabdh force-pushed the update-subscription-flow branch from 6f7cd8b to 94f9fb2 Compare November 4, 2022 06:58
@coveralls
Copy link

coveralls commented Nov 4, 2022

Pull Request Test Coverage Report for Build 3418019777

  • 404 of 722 (55.96%) changed or added relevant lines in 29 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-3.7%) to 77.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/notification/service.go 6 7 85.71%
core/subscription/service.go 18 19 94.74%
core/template/template.go 0 1 0.0%
internal/api/v1beta1/receiver.go 11 12 91.67%
internal/store/postgres/alerts.go 4 5 80.0%
internal/store/postgres/namespace.go 15 17 88.24%
internal/store/postgres/postgres.go 7 9 77.78%
core/alert/service.go 17 21 80.95%
core/provider/service.go 5 9 55.56%
internal/api/v1beta1/subscription.go 21 25 84.0%
Files with Coverage Reduction New Missed Lines %
internal/api/v1beta1/alert.go 2 94.94%
plugins/providers/cortex/service.go 2 35.64%
plugins/receivers/slack/option.go 3 30.77%
Totals Coverage Status
Change from base Build 3374641907: -3.7%
Covered Lines: 2770
Relevant Lines: 3570

💛 - Coveralls

@mabdh mabdh changed the title reafactor: update subscription flow and update plugins refactor: update subscription flow and update plugins Nov 4, 2022
@mabdh mabdh force-pushed the update-subscription-flow branch 11 times, most recently from 8fa25bf to fbe7e63 Compare November 4, 2022 11:19
@mabdh mabdh force-pushed the update-subscription-flow branch from fbe7e63 to ec7ccb7 Compare November 4, 2022 12:50
@mabdh mabdh merged commit f7ac109 into main Nov 8, 2022
@mabdh mabdh deleted the update-subscription-flow branch November 8, 2022 09:26
@mabdh mabdh linked an issue Nov 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subscription client CLI End-to-end test of notification service & updating the subscription flow
3 participants