Review suggestions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <[email protected]>
razajafri
reviewed
Jun 3, 2022
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/ExternalSource.scala
Show resolved
Hide resolved
razajafri
pushed a commit
that referenced
this pull request
Nov 12, 2023
… targets. (NVIDIA#9615) * Bloop updates - require JDK11 in buildall + docs, build bloop for all targets. Signed-off-by: Phil Dakin <[email protected]> * Address PR comments. Signed-off-by: Phil Dakin <[email protected]> * Add a bloopInstall profile (#1) * Add bloopInstall profile Signed-off-by: Gera Shegalov <[email protected]> * Add bloopInstall profile Fixes NVIDIA#9621 Signed-off-by: Gera Shegalov <[email protected]> * add comment for install in scala2.13 Signed-off-by: Gera Shegalov <[email protected]> * simplify Signed-off-by: Gera Shegalov <[email protected]> * undo unrelated Signed-off-by: Gera Shegalov <[email protected]> * Apply suggestions from code review Co-authored-by: PhilDakin <[email protected]> * review 1 Signed-off-by: Gera Shegalov <[email protected]> * Configurable bloopInstall phase Signed-off-by: Gera Shegalov <[email protected]> * move bloop config dir to execution conf Signed-off-by: Gera Shegalov <[email protected]> --------- Signed-off-by: Gera Shegalov <[email protected]> Co-authored-by: PhilDakin <[email protected]> * Propagate bloopInstall profile changes, make config directory overridable from command line. Signed-off-by: Phil Dakin <[email protected]> * Cleanup. Signed-off-by: Phil Dakin <[email protected]> --------- Signed-off-by: Phil Dakin <[email protected]> Signed-off-by: Gera Shegalov <[email protected]> Co-authored-by: Gera Shegalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gera Shegalov [email protected]