Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

v1.0.8: Daisy 🦆 #293

Merged
merged 3 commits into from
Nov 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ apply plugin: 'kotlin-android-extensions'

apply plugin: 'com.google.firebase.firebase-perf'

apply plugin: 'io.fabric'
apply plugin: 'com.google.firebase.crashlytics'

apply plugin: 'kotlin-kapt'

Expand Down Expand Up @@ -118,7 +118,7 @@ dependencies {
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:${versions.coroutines}"

// Architecture components
implementation "androidx.lifecycle:lifecycle-runtime:${versions.architectureComponents}"
implementation "androidx.lifecycle:lifecycle-runtime-ktx:${versions.architectureComponents}"
implementation "androidx.lifecycle:lifecycle-common-java8:${versions.architectureComponents}"
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:${versions.architectureComponents}"

Expand Down Expand Up @@ -162,10 +162,9 @@ dependencies {

implementation "androidx.room:room-ktx:${versions.room}"

implementation "com.crashlytics.sdk.android:crashlytics:${versions.crashlytics}"

// Firebase Performance
// Firebase
implementation "com.google.firebase:firebase-perf:${versions.firebasePerf}"
implementation "com.google.firebase:firebase-crashlytics:${versions.firebaseCrash}"

// Glide
// https://github.com/bumptech/glide
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@
android:name="preloaded_fonts"
android:resource="@array/preloaded_fonts" />

<meta-data
android:name="firebase_crashlytics_collection_enabled"
android:value="false" />

<activity
android:name=".MainActivity"
android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation"
Expand Down
9 changes: 4 additions & 5 deletions app/src/main/java/com/razeware/emitron/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,16 @@ import androidx.navigation.ui.AppBarConfiguration
import androidx.navigation.ui.navigateUp
import androidx.navigation.ui.setupWithNavController
import androidx.work.WorkManager
import com.crashlytics.android.Crashlytics
import com.google.android.gms.cast.framework.CastButtonFactory
import com.google.android.gms.cast.framework.CastContext
import com.google.firebase.crashlytics.FirebaseCrashlytics
import com.razeware.emitron.databinding.ActivityMainBinding
import com.razeware.emitron.di.modules.viewmodel.ViewModelFactory
import com.razeware.emitron.notifications.NotificationChannels
import com.razeware.emitron.ui.download.workers.PendingDownloadWorker
import com.razeware.emitron.ui.player.PipActionDelegate
import com.razeware.emitron.utils.extensions.*
import dagger.android.support.DaggerAppCompatActivity
import io.fabric.sdk.android.Fabric
import javax.inject.Inject


Expand Down Expand Up @@ -67,9 +66,9 @@ class MainActivity : DaggerAppCompatActivity() {
AppCompatDelegate.setDefaultNightMode(viewModel.getNightModeSettings())

// Collect crash reports only if user has allowed
if (viewModel.isCrashReportingAllowed()) {
Fabric.with(this, Crashlytics())
}
FirebaseCrashlytics
.getInstance()
.setCrashlyticsCollectionEnabled(viewModel.isCrashReportingAllowed())

requestGestureUi()
createNotificationChannels()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import androidx.navigation.fragment.findNavController
import androidx.navigation.navGraphViewModels
import androidx.navigation.ui.setupWithNavController
import androidx.work.WorkManager
import com.crashlytics.android.Crashlytics
import com.google.android.gms.oss.licenses.OssLicensesMenuActivity
import com.google.firebase.crashlytics.FirebaseCrashlytics
import com.razeware.emitron.BuildConfig
import com.razeware.emitron.R
import com.razeware.emitron.databinding.FragmentSettingsBinding
Expand All @@ -28,7 +28,6 @@ import com.razeware.emitron.ui.settings.SettingsBottomSheetDialogFragment.Compan
import com.razeware.emitron.utils.extensions.observe
import com.razeware.emitron.utils.extensions.setDataBindingView
import dagger.android.support.DaggerFragment
import io.fabric.sdk.android.Fabric
import javax.inject.Inject

/**
Expand Down Expand Up @@ -97,11 +96,12 @@ class SettingsFragment : DaggerFragment() {
}
}
crashReportingAllowed.observe(viewLifecycleOwner) {
it?.let {
binding.switchCrashReporting.isChecked = it
if (it) {
Fabric.with(requireContext(), Crashlytics())
}
it?.let { hasUserEnabledCrashReporting ->
binding.switchCrashReporting.isChecked = hasUserEnabledCrashReporting

FirebaseCrashlytics
.getInstance()
.setCrashlyticsCollectionEnabled(hasUserEnabledCrashReporting)
}
}
playbackQuality.observe(viewLifecycleOwner) {
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/com/razeware/emitron/utils/Log.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.razeware.emitron.utils

import android.util.Log
import com.crashlytics.android.Crashlytics
import com.google.firebase.crashlytics.FirebaseCrashlytics
import com.razeware.emitron.BuildConfig
import com.razeware.emitron.data.settings.SettingsRepository
import javax.inject.Inject
Expand Down Expand Up @@ -59,7 +59,7 @@ internal object Log {
if (BuildConfig.DEBUG) {
e.printStackTrace()
} else {
Crashlytics.logException(e)
FirebaseCrashlytics.getInstance().recordException(e)
}
}

Expand All @@ -70,7 +70,7 @@ internal object Log {
if (BuildConfig.DEBUG) {
e.printStackTrace()
} else {
Crashlytics.logException(e)
FirebaseCrashlytics.getInstance().recordException(e)
}
}
}
26 changes: 11 additions & 15 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
buildscript {
ext.versions = [
// build
'versionCode' : 22,
'versionName' : "1.0.7",
'versionCode' : 23,
'versionName' : "1.0.8",
'minSdk' : 21,
'targetSdk' : 30,
'compileSdk' : 30,
'gradle' : '4.0.1',
'kotlin' : '1.4.0',
'gradle' : '4.1.0',
'kotlin' : '1.4.10',

// core
'coreKtx' : "1.3.1",
'coreKtx' : "1.3.2",
'fragmentKtx' : "1.2.5",
'preferenceKtx' : "1.1.1",
'architectureComponents' : "2.2.0",
Expand All @@ -22,17 +22,17 @@ buildscript {
'multidex' : "2.0.1",
'browser' : "1.2.0", // Chrome custom tabs

'dagger' : '2.27',
'dagger' : '2.28.3',
'coroutines' : "1.3.9",

// cast
'mediarouter' : "1.1.0",
'castFramework' : '17.1.0', // Google cast

// ui
'constraintLayout' : "2.0.1",
'constraintLayout' : "2.0.2",
'exoplayer' : "2.10.4",
'navigation' : "2.3.0",
'navigation' : "2.3.1",
'materialDesign' : '1.2.1',
'vectorDrawable' : '1.1.0',
'recyclerView' : "1.0.0",
Expand All @@ -55,7 +55,7 @@ buildscript {

//quality
'ktlint' : "0.33.0",
'crashlytics' : "2.10.1",
'crashlytics' : "2.3.0",

//test
'powerMock' : "2.0.2",
Expand All @@ -69,13 +69,13 @@ buildscript {
// firebase
'firebaseConfig' : '18.0.0',
'firebasePerf' : '19.0.2',
'firebaseCrash' : '17.2.2',

// play services
'playOss' : '17.0.0',

// plugins
'firebasePerfPlugin' : "1.2.1",
'fabricToolsPlugin' : "1.29.0",
'jacocoPlugin' : "0.8.1",
'googleServicesPlugin' : "4.2.0",
'ossLicenses' : "0.9.5"
Expand All @@ -84,21 +84,17 @@ buildscript {
repositories {
google()
jcenter()

maven {
url 'https://maven.fabric.io/public'
}
}

dependencies {
classpath "com.android.tools.build:gradle:${versions.gradle}"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${versions.kotlin}"
classpath "io.fabric.tools:gradle:${versions.fabricToolsPlugin}"
classpath "org.jacoco:org.jacoco.core:${versions.jacocoPlugin}"
classpath "com.google.gms:google-services:${versions.googleServicesPlugin}"
classpath "com.google.firebase:perf-plugin:${versions.firebasePerfPlugin}"
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:${versions.navigation}"
classpath "com.google.android.gms:oss-licenses-plugin:${versions.ossLicenses}"
classpath "com.google.firebase:firebase-crashlytics-gradle:${versions.crashlytics}"
}
}

Expand Down
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Mon Sep 14 16:50:38 CEST 2020
#Sun Oct 18 14:44:29 CEST 2020
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip
1 change: 0 additions & 1 deletion release-notes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
## Changes
- Added a swipe to refresh on the Library screen.
- Various bug fixes and enhancements.