Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Additions of New Tags Permission to Android #353

Merged

Conversation

KelvnPere
Copy link
Contributor

Based on the title, there were some new permissions that were added which includes "stream-team-videos" and "stream-personal-videos" which was causing some users to not have access to some contents. Also, 2 tests were written to verify the permission checks during the login session.

Here is a link to the issue #352

@sammyd sammyd self-requested a review June 8, 2023 09:04
Copy link
Collaborator

@sammyd sammyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Not sure I follow it completely, but it seems ok to me at first glance. Thanks!

@KelvnPere
Copy link
Contributor Author

👍 Not sure I follow it completely, but it seems ok to me at first glance. Thanks!

Its there a way to actually test it, with user accounts? @sammyd

@sammyd
Copy link
Collaborator

sammyd commented Jun 8, 2023

If you sign up for a new kodeco account, I can give you the new permissions and you can give it a try?

@KelvnPere
Copy link
Contributor Author

If you sign up for a new kodeco account, I can give you the new permissions and you can give it a try?

Here is the new account, LMK when you have done it. Also where in particular should test it in the app?

Username: @dev_testing

@KelvnPere
Copy link
Contributor Author

If you sign up for a new kodeco account, I can give you the new permissions and you can give it a try?

Here is the new account, LMK when you have done it. Also where in particular should test it in the app?

Username: @dev_testing

@sammyd Not sure if you missed this, have the access been granted to the account?

@sammyd
Copy link
Collaborator

sammyd commented Jun 15, 2023

@KelvnPere So sorry for the delay—I've been out of the office this week. This account should now have the required access.

@KelvnPere
Copy link
Contributor Author

@KelvnPere So sorry for the delay—I've been out of the office this week. This account should now have the required access.

No issues, that's totally fine. Can you provide me like a keyword search so i can fully test the app with that account. In other words, the videos that one with that access should have access to. Thanks

@sammyd

@KelvnPere
Copy link
Contributor Author

@sammyd still waiting on you for the above. Thanks

@sammyd
Copy link
Collaborator

sammyd commented Jun 30, 2023

@KelvnPere sorry I completely missed this comment. That account should have access to all videos.

- stream-teams permission and personal to the collection page.
@KelvnPere
Copy link
Contributor Author

@sammyd I have tested it from my end and it looks good. Also, i think the dev_testing in the collection page was showing some contents locked which i feel has to do with the correct permissions. When i tested it with my normal work kodeco account it showed correctly and fine.

This is good from my end.

@KelvnPere KelvnPere merged commit 370a74b into razeware:development Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants