This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Lock Tag icon height for time-being to prevent parent view rendering issue #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bladebunny It looks like your change is automatically failing the tests because it didn't pass the Swift Linter. You'll need to enable it on this project. I believe the README details how to do this. Would you mind fixing and updating this PR? Thanks! |
|
@VegetarianZombie NP - later today or tomorrow. |
|
@sammyd does the app work with dynamic type at the moment? |
Fixing swiftlint issue
|
Please disregard the commit title. No idea where that came from. I think it was an artifact from my Git client. The message is correct - this update fixes the swiftlint issue and looks like checks and tests passed. |
|
@0xTim yes—it does. Might not be throughout, but most of it should yes. Brian did some work on this for the last release. |
0xTim
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locking TagView icon height for time-being to resolve size rendering issue
If you accept the PR, would you mind adding the
hacktoberfest-acceptedlabel?#493