Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

update SwiftLint workflow to match readme & Fix's Swiftlint warnings for version 0.41.0 #530

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

byaruhaf
Copy link
Contributor

@byaruhaf byaruhaf commented Nov 10, 2020

Updated the SwiftLint workflow to match readme and build process used
SwiftLint is installed by brew on macos-latest then run with swiftlint --config Emitron/.swiftlint.ym

These changes will fix the following swiftlint warnings for version 0.41.0

  • Inclusive Language Violation: Declaration hasWhiteListedIdentifier contains the term "whitelist" which is not considered inclusive. (inclusive_language)
  1. SnapshotHelper.swift:251:7
  2. SnapshotHelper.swift:252:9
  • Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace)
  1. Constants.swift:49:20
  2. JSONAPIRelationship.swift:35:30
  3. JSONAPIDocument.swift:36:30
  4. Parameters.swift:209:12
  • Unused Closure Parameter Violation: Unused parameter "path" in a closure should be replaced with _. (unused_closure_parameter)
  1. DownloadService.swift:558:54

SnapshotHelper.swift:251:7: Inclusive Language Violation: Declaration hasWhiteListedIdentifier contains the term "whitelist" which is not considered inclusive. (inclusive_language)
SnapshotHelper.swift:252:9: Inclusive Language Violation: Declaration whiteListedIdentifiers contains the term "whitelist" which is not considered inclusive. (inclusive_language)
Constants.swift:49:20: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace)
JSONAPIRelationship.swift:35:30: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace)
JSONAPIDocument.swift:36:30: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace)
Parameters.swift:209:12: Operator Usage Whitespace Violation: Operators should be surrounded by a single whitespace when they are being used. (operator_usage_whitespace)
DownloadService.swift:558:54: Unused Closure Parameter Violation: Unused parameter "path" in a closure should be replaced with _. (unused_closure_parameter)
@byaruhaf byaruhaf changed the title Fix's Swiftlint warnings update SwiftLint workflow to match readme & Fix's Swiftlint warnings for version 0.41.0 Nov 10, 2020
Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xTim 0xTim merged commit 414c2c6 into razeware:development Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants