This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sammyd
commented
Feb 6, 2023
- Reskinning and renaming for rebranding to Kodeco.
- Restricting to iOS 16 minimum deployment version.
- Fixing long-running bug with displaying progress.
- Fixed a crash relating to Combine deadlock.
- Removed ability to choose icon.
As per Figma spec for Any, Light and Dark.
Only dark mode needs to be set.
To conform to naming conventions in the project.
Kodeco Reskin
Matched borderColor and cardBackground to Kodeco colors.
Kodeco Reskin Iteration 2
Code formatting fixes as per SwiftLint
Prepping for release
Otherwise the button takes ages to work, and it's calling UI methods on a background thread.
Turns out, the state does not need to be published. And we need another state to reduce the number of times it reloads. This is all a bit hacky, but the app doesn't hang or crash at the moment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.