Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new API endpoints #366

Merged
merged 7 commits into from
Dec 18, 2023
Merged

feat: Added new API endpoints #366

merged 7 commits into from
Dec 18, 2023

Conversation

@ankitdas13 ankitdas13 requested a review from ndhaka007 December 5, 2023 07:35
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 49.45%. Comparing base (4d11a22) to head (99b1972).
Report is 7 commits behind head on master.

Files Patch % Lines
src/Customer.php 0.00% 12 Missing ⚠️
src/Dispute.php 0.00% 12 Missing ⚠️
src/Account.php 0.00% 7 Missing ⚠️
src/Entity.php 0.00% 7 Missing ⚠️
src/Stakeholder.php 0.00% 7 Missing ⚠️
src/Order.php 0.00% 6 Missing ⚠️
src/Document.php 0.00% 5 Missing ⚠️
src/Settlement.php 0.00% 5 Missing ⚠️
src/Iin.php 0.00% 3 Missing ⚠️
src/Payment.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     53.88%   49.45%   -4.43%     
- Complexity      234      255      +21     
============================================
  Files            32       34       +2     
  Lines           670      734      +64     
============================================
+ Hits            361      363       +2     
- Misses          309      371      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Entity.php Outdated
@@ -231,4 +231,16 @@ protected function convertToArray($attributes)

return $array;
}

public function convertToFile($attributes)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to setFile

Copy link

@ndhaka007 ndhaka007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just change the name of function that we discussed

@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Dec 14, 2023
@ankitdas13 ankitdas13 merged commit 0f90a48 into master Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants