Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win] New Fixes for Finder Mods (2024-06) #867

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RedBearAK
Copy link
Contributor

@RedBearAK RedBearAK commented Jun 11, 2024

@rbreaves

Finder Mods for Windows Explorer had a number of issues that needed to be fixed, primarily coming from how the comparison was being made between the ClassNN attribute and a list of different possible strings to match on, for certain keys and shortcuts.

All issues with Enter, Backspace, Cmd+Backspace (Delete) and the Delete key seem to have been resolved in my testing on Windows 11. Renaming with Enter works on the desktop, and Cmd+Backspace is properly blocked to prevent deleting files on the desktop. Tab navigation shortcuts still working.

Finder Mods for Windows Explorer had a number of issues that needed to be fixed, primarily coming from how the comparison was being made between the `ClassNN` attribute and a list of different possible strings to match on, for certain keys and shortcuts. 

All issues with Enter, Backspace, Cmd+Backspace (Delete) and the Delete key seem to have been resolved in my testing on Windows 11. Renaming with Enter works on the desktop, and Cmd+Backspace is properly blocked to prevent deleting files on the desktop. Tab navigation shortcuts still working.
@RedBearAK
Copy link
Contributor Author

RedBearAK commented Jun 11, 2024

@rbreaves

And of course after jumping into a different account on the same Windows 11 machine, I ran into a few more issues, and inconsistent ClassNN naming of different sections of the Explorer window. But I put in some additional logic to keep an error dialog from appearing in an old Control Panel window (Fonts), which is still part of Explorer.

It looks like I can't completely block the accidental usage of the Delete key in the desired places, but at least the fix for accidentally deleting a bunch of files on the desktop with Cmd+Backspace should still be working.

This PR should fix the same problem mentioned in issue #787, that was also something targeted by PR #795. I think I'll close that older PR, and also PR #769. They are obsoleted by this PR.

Edit: And also PR #768 is included in this PR, so closed that too.

@RedBearAK
Copy link
Contributor Author

@rbreaves

Added another minor tweak that tries to get Cmd+Down to work on the desktop, for opening files and folders in place of the Enter key.

I've noticed a lot of strange inconsistency in both Explorer windows and the desktop, where sometimes things just don't work as intended right away, but the later they do, as if the ClassNN is different at first and doesn't match. Or perhaps there is some other cause related to restarting the AutoHotkey script to test the changes.

But once it starts working, it seems to keep working after that.

I'm not aware of anything else I can improve upon with this PR at this time, and I'm done updating this Win11 machine, so I probably won't mess with this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant