updated pre-commit tests

rbroderi · May 12, 2022 · e55e48e · e55e48e
1 parent fa07e9c
commit e55e48e
Show file tree

Hide file tree

Showing 5 changed files with 1,479 additions and 1,458 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -52,6 +52,12 @@ repos:
         name: "Python: Formating files"
         args: [--line-length=88, --preview, --safe]
         types: [file, python]
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v2.32.1
+    hooks:
+      - id: pyupgrade
+        name: "Python: upgrade syntax"
+        args: [--py37-plus]
   - repo: https://github.com/hadialqattan/pycln
     rev: v1.3.2
     hooks:
@@ -93,6 +99,7 @@ repos:
         # making isort line length compatible with black
           - "--max-line-length=88"
           - "--max-complexity=18"
+          - "--kwargs-max-positional-arguments=4"
         # allowing these errors now that in the past we ignored.
         # D100 Missing docstring in public module
         # D103 Missing docstring in public function
@@ -131,7 +138,13 @@ repos:
           - flake8-colors
           - flake8-tuple
           - pandas-vet
-         # - wemake-python-styleguide
+          - flake8-length
+          - flake8-assertive
+          - flake8-warnings
+          - flake8-comprehensions
+          - flake8-simplify
+          - flake8-noqa
+          - flake8-force-keyword-arguments
         exclude: "setup[.]py|conf[.]py|__init__[.]py"
         types: [file, python]
   - repo: https://github.com/asottile/add-trailing-comma

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -12,5 +12,9 @@
         "pylance",
         "pyright",
         "Verbex"
+    ],
+    "python.linting.flake8Enabled": true,
+    "python.linting.flake8Args": [
+        "--ignore=E501"
     ]
 }
diff --git a/check_names.py b/check_names.py
@@ -50,20 +50,18 @@ def main() -> int:
                 print(f"ERROR: '{module_name}' is not all lowercase with underscores")
                 return ExitCode.DATA_ERR
         # check package if exists
-        if package_name.strip() != "":
-            # check package name
-            if not re.fullmatch("[A-Za-z]+", package_name):
-                if re.fullmatch("[A-Za-z0-9]+", package_name):
-                    print(
-                        f"WARNING: '{package_name}' has numbers - allowing but note"
-                        " this is not 'strictly' to pep 8 best practices",
-                    )
-                else:
-                    print(
-                        f"ERROR: '{package_name}' is not all lowercase with no"
-                        " underscores",
-                    )
-                    return ExitCode.DATA_ERR
+        # check package name
+        if package_name.strip() != "" and not re.fullmatch("[A-Za-z]+", package_name):
+            if re.fullmatch("[A-Za-z0-9]+", package_name):
+                print(
+                    f"WARNING: '{package_name}' has numbers - allowing but note"
+                    " this is not 'strictly' to pep 8 best practices",
+                )
+            else:
+                print(
+                    f"ERROR: '{package_name}' is not all lowercase with no underscores",
+                )
+                return ExitCode.DATA_ERR
     return ExitCode.OK