Sync with new block message proto #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrospic
reviewed
May 12, 2022
rchain/crypto.py
Outdated
| block.sender, | ||
| StringValue(value=block.sigAlgorithm).SerializeToString(), | ||
| Int32Value(value=block.seqNum).SerializeToString(), | ||
| StringValue(value=block.shardId).SerializeToString(), | ||
| block.extraBytes]) | ||
| StringValue(value=block.shardId).SerializeToString()]) |
There was a problem hiding this comment.
Block hash must include all fields except signature and block hash.
https://github.com/rchain/rchain/pull/3688/files#diff-4a2241d942011ebc9d96deb51072793f5fc957fc3da883deab43e721aec7e34cR86-R95
Serialize can be called on the whole BlockMessageProto object with these two fields deleted. If it's mutable copy can be created.
* `body` changed to `state` according to rchain/rchain@fa6a47b#diff-9b93ccfb0ddb3556f4e99cb75e47ce157b09ee1e5ec469880d404c8c15b394e0 * hashing is implemented as in rchain/rchain@86e1d28
stanislavlyalin
force-pushed
the
sync-with-new-block-message-proto
branch
from
6e213de to
90ea9bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of this library in accordance with the changes in the proto files in Block metadata refactoring (part 2) PR. Fixed broken tests.