Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and flag applicable diagnostics with DiagnosticTag.Unnecessary #82

Closed
rcjsuen opened this issue Jul 11, 2020 · 0 comments
Closed

Review and flag applicable diagnostics with DiagnosticTag.Unnecessary #82

rcjsuen opened this issue Jul 11, 2020 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 11, 2020

Like #80, we should flag any applicable diagnostics with DiagnosticTag.Unnecessary. Good candidates would be errors where things are duplicated (such as the escape parser directive in #70).
@rcjsuen rcjsuen self-assigned this Jul 11, 2020
rcjsuen added a commit that referenced this issue Aug 29, 2021
@rcjsuen
WIP #82 Flag duplicated parser directive diagnostics as being unneces…
45cbdfa 
…sary

Signed-off-by: Remy Suen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen