Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #issue-70 related to get_json_object functionality for hive-serde #71

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixed #issue-70 related to get_json_object functionality for hive-serde #71

wants to merge 3 commits into from

Conversation

snehalNagmote
Copy link

This issue is related to get_json_object does not work with hive serde on Json String unless one defines it as struct.
#70

@snehalNagmote
Copy link
Author

I fixed this by adding String object inspector that would handle Json and tested it , it works, Look forward to your review and comments .

@ashokkumar-dhanavel
Copy link

I have recently reported a similar issue with get_json_object,

#82

then I merged with develop branch with pull request and its working perfectly. Is this eventually going to merge with developing branch ?

@rcongiu
Copy link
Owner

rcongiu commented Sep 11, 2014

This pull request is mostly formatting changes and can't be merged automatically.
When a pull request is like that, it's much harder to review. Please do keep in mind I work on this on my spare time. Can you please submit a pull request or a diff for just the relevant change ?

@snehalNagmote
Copy link
Author

Apologies for inconvenience . My IDE messed up with formatting , but I did
revert back those formatting changes after I created pull request . If you
look into files changed , you should be able to figure out the relevant
changes/diff , Or I would submit new pull request by tomorrow

Let me know ,

Thanks,
Snehal

On 10 September 2014 23:29, Roberto Congiu [email protected] wrote:

This pull request is mostly formatting changes and can't be merged
automatically.
When a pull request is like that, it's much harder to review. Please do
keep in mind I work on this on my spare time. Can you please submit a pull
request or a diff for just the relevant change ?

—
Reply to this email directly or view it on GitHub
#71 (comment)
.

wmoss pushed a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 18, 2014
Fix for #issue-70 related to get_json_object
ce401c3 
This is a reworking of 
rcongiu#71 to update it to the
new directory structure in 1.3
wmoss pushed a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 18, 2014
Fix for #issue-70 related to get_json_object
d1aa01c 
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3
wmoss pushed a commit to wmoss/Hive-JSON-Serde that referenced this pull request Sep 19, 2014
Fix for #issue-70 related to get_json_object
6770f89 
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3
This was referenced Sep 19, 2014
Closed
Merged
@dblock
Copy link
Contributor

dblock commented Apr 2, 2017

This should be closed via #90.

MelonTennis pushed a commit to MelonTennis/Hive-JSON-Serde that referenced this pull request Jun 20, 2017
r - Fix for #issue-70 related to get_json_object
813aa07 
This is a reworking of
rcongiu#71 to update it to the
new directory structure in 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snehalNagmote @ashokkumar-dhanavel @rcongiu @dblock