add some syscalls and add stdin #131

yukiiiteru · 2020-08-07T01:53:29Z

No description provided.

coveralls · 2020-08-07T01:58:47Z

Pull Request Test Coverage Report for Build 201287677

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

7 of 124 (5.65%) changed or added relevant lines in 9 files are covered.
71 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.4%) to 32.276%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
linux-object/src/error.rs	0	1	0.0%
linux-syscall/src/lib.rs	0	4	0.0%
linux-syscall/src/task.rs	0	5	0.0%
linux-object/src/fs/file.rs	0	6	0.0%
linux-syscall/src/misc.rs	0	21	0.0%
linux-object/src/fs/stdio.rs	4	36	11.11%
linux-syscall/src/file/poll.rs	0	48	0.0%

Files with Coverage Reduction	New Missed Lines	%
../../../../../usr/share/rust/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs	3	39.22%
../../../../../usr/share/rust/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/async-task-3.0.0/src/raw.rs	4	67.83%
../../../../../usr/share/rust/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/async-task-3.0.0/src/waker_fn.rs	4	80.95%
linux-syscall/src/misc.rs	10	18.18%
linux-object/src/fs/file.rs	18	55.15%
linux-syscall/src/task.rs	32	8.07%

Totals
Change from base Build 198552974:	-0.4%
Covered Lines:	4092
Relevant Lines:	12678

💛 - Coveralls

yukiiiteru · 2020-08-07T06:55:44Z

代码没通过 cargo clippy，下次注意qwq

wangrunji0408

后续有修改直接 commit 到原分支 push 即可，force push 也可以，不需要另开新 PR 了。

linux-syscall/src/misc.rs

linux-object/src/fs/stdio.rs

linux-syscall/src/task.rs

yunwei37 · 2020-08-07T15:13:17Z

Maybe you can help us add more document and unit test for these syscalls?

: )

yukiiiteru · 2020-08-08T02:21:38Z

Maybe you can help us add more document and unit test for these syscalls?

: )

Of course, but my main work is software transportation. Therefore, I will add necessary documents for syscalls to pass the check of #[deny(missing_doc)].

BTW, what I've finished is, for example, sys_getrandom, sys_poll, sys_nanosleep. Maybe it's complex to write unit tests for them.

_(:з」∠)_

wangrunji0408 · 2020-08-08T14:52:14Z

I think unit test is only necessary for objects. Syscall layer can be tested in the loader crate.

yunwei37 · 2020-08-08T15:23:38Z

qwq....I just mean maybe we can write unit test in in the loader crate like this ? #132

merge upstream code

wangrunji0408 · 2020-08-10T02:28:33Z

qwq....I just mean maybe we can write unit test in in the loader crate like this ? #132

Exactly!

linux-syscall/src/task.rs

linux-syscall/src/misc.rs

linux-loader/Cargo.toml

linux-object/Cargo.toml

linux-object/src/process.rs

linux-syscall/src/file/poll.rs

Merge

Co-authored-by: Runji Wang <[email protected]>

linux-object/src/process.rs

linux-syscall/src/misc.rs

Co-authored-by: Runji Wang <[email protected]>

wangrunji0408

辛苦辛苦了😂

yukiiiteru · 2020-08-11T13:11:10Z

rjgg 也辛苦了

我还是要认真读代码啊，尽量少出这种问题

现在 push 之前会习惯性用 cargo fmt 和 cargo clippy 检查代码了，也算是有点进步x

* add sys_getrandom and sys_nanosleep * add stdin * fix sys_nanosleep * update rcore-fs and add sys_poll * add sys_prlimit64 * fix color problem of ls * fix a problem of compiling zCore * add gdbinit for make debug * fix typo of flag * Update linux-syscall/src/file/poll.rs Co-authored-by: Runji Wang <[email protected]> * Update linux-syscall/src/file/poll.rs Co-authored-by: Runji Wang <[email protected]> * remove comment * remove pub at inner * fix a problem of pointer * fix arg of nanosleep * Update linux-syscall/src/misc.rs Co-authored-by: Runji Wang <[email protected]> * remove pub * fix a problem of null ptr in sys_prlimit Co-authored-by: Runji Wang <[email protected]>

wangrunji0408 requested changes Aug 7, 2020

View reviewed changes

linux-syscall/src/misc.rs Outdated Show resolved Hide resolved

linux-syscall/src/misc.rs Outdated Show resolved Hide resolved

linux-syscall/src/misc.rs Outdated Show resolved Hide resolved

linux-object/src/fs/stdio.rs Outdated Show resolved Hide resolved

wangrunji0408 added the enhancement New feature or request label Aug 7, 2020

yukiiiteru added 2 commits August 7, 2020 16:56

add sys_getrandom and sys_nanosleep

13eb287

add stdin

1a762d2

wangrunji0408 requested changes Aug 7, 2020

View reviewed changes

linux-syscall/src/task.rs Outdated Show resolved Hide resolved

yukiiiteru added 3 commits August 7, 2020 17:22

fix sys_nanosleep

c21eb5c

update rcore-fs and add sys_poll

2b809c2

add sys_prlimit64

baaff5f

yukiiiteru changed the title ~~add sys_getrandom, add stdin without condvar~~ add some syscalls and add stdin Aug 7, 2020

yukiiiteru added 2 commits August 8, 2020 20:09

fix color problem of ls

744906f

fix a problem of compiling zCore

afb3bc4

yukiiiteru and others added 2 commits August 9, 2020 15:31

add gdbinit for make debug

2596031

Merge pull request #1 from rcore-os/master

d72435e

merge upstream code

yukiiiteru and others added 3 commits August 11, 2020 10:45

Merge branch 'master' into master

f7aa547

fix typo of flag

e3232c3

Merge branch 'master' of github.com:wfly1998/zCore

c4b4a37

wangrunji0408 requested changes Aug 11, 2020

View reviewed changes

yukiiiteru and others added 5 commits August 11, 2020 18:34

Merge pull request #3 from rcore-os/master

0004aba

Merge

Update linux-syscall/src/file/poll.rs

b88b97a

Co-authored-by: Runji Wang <[email protected]>

Update linux-syscall/src/file/poll.rs

f86cdf8

Co-authored-by: Runji Wang <[email protected]>

remove comment

1be5e62

remove pub at inner

b836cb4

yukiiiteru added 2 commits August 11, 2020 19:04

fix a problem of pointer

0de2876

fix arg of nanosleep

8bd2c60

yukiiiteru requested a review from wangrunji0408 August 11, 2020 11:27

wangrunji0408 requested changes Aug 11, 2020

View reviewed changes

yukiiiteru and others added 3 commits August 11, 2020 20:28

Update linux-syscall/src/misc.rs

d73486e

Co-authored-by: Runji Wang <[email protected]>

remove pub

7b55dc0

fix a problem of null ptr in sys_prlimit

b897de3

yukiiiteru requested a review from wangrunji0408 August 11, 2020 12:44

wangrunji0408 approved these changes Aug 11, 2020

View reviewed changes

wangrunji0408 merged commit 2c6893e into rcore-os:master Aug 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add some syscalls and add stdin #131

add some syscalls and add stdin #131

yukiiiteru commented Aug 7, 2020

coveralls commented Aug 7, 2020 •

edited

Loading

yukiiiteru commented Aug 7, 2020

wangrunji0408 left a comment

yunwei37 commented Aug 7, 2020 •

edited

Loading

yukiiiteru commented Aug 8, 2020

wangrunji0408 commented Aug 8, 2020

yunwei37 commented Aug 8, 2020

wangrunji0408 commented Aug 10, 2020

wangrunji0408 left a comment

yukiiiteru commented Aug 11, 2020

add some syscalls and add stdin #131

add some syscalls and add stdin #131

Conversation

yukiiiteru commented Aug 7, 2020

coveralls commented Aug 7, 2020 • edited Loading

Pull Request Test Coverage Report for Build 201287677

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

yukiiiteru commented Aug 7, 2020

wangrunji0408 left a comment

Choose a reason for hiding this comment

yunwei37 commented Aug 7, 2020 • edited Loading

yukiiiteru commented Aug 8, 2020

wangrunji0408 commented Aug 8, 2020

yunwei37 commented Aug 8, 2020

wangrunji0408 commented Aug 10, 2020

wangrunji0408 left a comment

Choose a reason for hiding this comment

yukiiiteru commented Aug 11, 2020

coveralls commented Aug 7, 2020 •

edited

Loading

yunwei37 commented Aug 7, 2020 •

edited

Loading