Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH90 - interactive ssh shell #91

Merged
merged 2 commits into from
Sep 17, 2024
Merged

GH90 - interactive ssh shell #91

merged 2 commits into from
Sep 17, 2024

Conversation

zghp
Copy link
Contributor

@zghp zghp commented Sep 5, 2024

No description provided.

@zghp zghp requested a review from TB-1993 September 5, 2024 16:12
@zghp zghp self-assigned this Sep 5, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

zghp seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

TB-1993
TB-1993 requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@TB-1993 TB-1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ultimately we need a complete overhaul of our console classes to get them all behaving the same. They all have minor differences at the moment and it will ruin our tests.

framework/core/commandModules/sshConsole.py Outdated Show resolved Hide resolved
framework/core/deviceManager.py Outdated Show resolved Hide resolved
framework/core/commandModules/sshConsole.py Outdated Show resolved Hide resolved
framework/core/commandModules/sshConsole.py Outdated Show resolved Hide resolved
framework/core/commandModules/sshConsole.py
while self.buffer.__len__() > 0:
data = data + self.buffer.pop(0)
return data
return self.full_output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could continue to use buffer here and still do this as a list. Then we wouldn't need the new attribute and wouldn't change the behaviour of the method too much.

@TB-1993 TB-1993 linked an issue Sep 12, 2024 that may be closed by this pull request
SSHConsole should be interactive terminal #90
Closed
@TB-1993 TB-1993 added the enhancement New feature or request label Sep 12, 2024
@zghp zghp force-pushed the feature/gh90_interactive_ssh_shell branch from 657eb5e to 762009a Compare September 17, 2024 09:24
TB-1993
TB-1993 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@TB-1993 TB-1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@zghp zghp merged commit fe79622 into develop Sep 17, 2024
2 of 3 checks passed
@zghp zghp deleted the feature/gh90_interactive_ssh_shell branch September 17, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TB-1993 TB-1993 TB-1993 approved these changes

Assignees

@zghp zghp

Labels
enhancement New feature or request
Projects
None yet
Milestone
python_raft 1.1.0: Unittest Library I...
Development

Successfully merging this pull request may close these issues.

SSHConsole should be interactive terminal
3 participants
@zghp @CLAassistant @TB-1993