Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionset Provider Depending on User #430

Closed
m6121 opened this issue Mar 17, 2022 · 3 comments
Closed

Optionset Provider Depending on User #430

m6121 opened this issue Mar 17, 2022 · 3 comments
Assignees
@jochenklar
Labels
effort:minor type:feature-request
Milestone
RDMO 2.2.0

Comments

@m6121
Copy link
Member

m6121 commented Mar 17, 2022

Extending the optionset provider interface so that this includes the current user in addition to the project and search information might enable new usage scenarios. The idea is that another non-public service is queried depending on the user and the result is used as dynamic optionset.
@jochenklar
Copy link
Member

Yes, I like it. Maybe we should just generally hand over the request object to plugins. We can then also get rid of the search parameter here.

@jochenklar jochenklar self-assigned this Aug 29, 2023
@jochenklar jochenklar added this to the 2.1.0 milestone Aug 29, 2023
@jochenklar jochenklar modified the milestones: 2.1.0, 2.2.0 Jan 19, 2024
jochenklar added a commit that referenced this issue Jun 3, 2024
@jochenklar
Add user and site to options provider (#430)
7dfc2f9
@jochenklar jochenklar mentioned this issue Jun 3, 2024
Merged
@jochenklar
Copy link
Member

Adding the full request to the provider or replacing the search parameter might raise compatibility issues, so I just added the user (and the site, because why not). Other information from the request does not seem nessesary.

MyPyDavid pushed a commit that referenced this issue Jun 19, 2024
@jochenklar @MyPyDavid
Add user and site to options provider (#430)
d49034a
MyPyDavid pushed a commit that referenced this issue Jun 19, 2024
@jochenklar @MyPyDavid
Add user and site to options provider (#430)
99d4894
jochenklar added a commit that referenced this issue Jun 20, 2024
@jochenklar
Add user and site to options provider (#430)
c5b4ca0
jochenklar added a commit that referenced this issue Jul 8, 2024
@jochenklar
Merge pull request #1013 from rdmorganiser/add_user_and_site_to_optio…
6ddcee6 
…ns_provider

Add user and site to options provider (#430)
@jochenklar
Copy link
Member

Will be part of RDMO 2.2.0.

@jochenklar jochenklar mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jochenklar jochenklar

Labels
effort:minor type:feature-request
Projects
None yet
Milestone
RDMO 2.2.0
Development

No branches or pull requests
2 participants
@jochenklar @m6121