Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos (found by codespell and typos) #1002

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

stweil
Copy link
Contributor

@stweil stweil commented May 22, 2024

Description

Related issue: #1001

Motivation and Context

I noticed a typo while using the software.

How has this been tested?

Manual review of the changes.

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stweil
Copy link
Contributor Author

stweil commented May 22, 2024

Note that I did not update the .mo files. The next regular update of these files will get the changes from the .po files automatically.

@stweil stweil changed the title Fix some typos (found by codespell) Fix some typos (found by codespell and typos) May 22, 2024
@Zack-83 Zack-83 merged commit 065d195 into rdmorganiser:main May 30, 2024
5 checks passed
@coveralls
Copy link

Coverage Status

coverage: 91.591%. remained the same
when pulling aa2a890 on stweil:typos
into c945d7d on rdmorganiser:main.

@MyPyDavid
Copy link
Member

why was this merged on the main branch? Thought we have currently the dev-2.2.0 for that...

@stweil stweil deleted the typos branch June 3, 2024 09:09
@Zack-83
Copy link
Member

Zack-83 commented Jun 3, 2024

My mistake :(

@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone Jun 3, 2024
@MyPyDavid
Copy link
Member

we need to check if the changes to translations in the migration files require new migrations..
and now the dev-2.2.0 related branches need to be rebased to this new main ..

@jochenklar
Copy link
Member

I think we should rebase dev-2.2.0 after we merge most of the feature branches.

@jochenklar
Copy link
Member

Migrations and translations seem ok. The changed migrations are old, and the translations were changed in the same way in the code and the .po files.

@MyPyDavid MyPyDavid linked an issue Jun 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos in English text (documentation, comments, ...)
5 participants