Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all catalogs #1201

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Show all catalogs #1201

merged 5 commits into from
Dec 5, 2024

Conversation

CalamityC
Copy link
Collaborator

Description

Related issue: #ISSUE_NUMBER

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

@CalamityC CalamityC changed the base branch from main to 2.3.0 November 26, 2024 15:35
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny thing, if the non-available catalog is selected it is barely readable (dark-gray on blue). Can you add a css rule to make text-muted white when active?

Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jochenklar
Copy link
Member

@CalamityC can we merge this?

@CalamityC
Copy link
Collaborator Author

CalamityC commented Dec 2, 2024

@CalamityC can we merge this?

Can we wait until I showed the outcome to Jürgen? I probably speak to him tomorrow
And should I merge then? Or you?

@jochenklar
Copy link
Member

sure.

@CalamityC CalamityC marked this pull request as ready for review December 5, 2024 11:24
@CalamityC CalamityC merged commit c486085 into 2.3.0 Dec 5, 2024
19 checks passed
@CalamityC CalamityC deleted the show-all-catalogs branch December 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants