Update for Bootstrap 3.3: render a .modal-backdrop inside of its .modal. #330
Conversation
In Bootstrap 3.3.0, the `.modal-backdrop` was moved inside its corresponding `.modal`. See: twbs/bootstrap#14724 With this, the `z-index` was removed from the `.modal-backdrop`, meaning that modal backdrops in React Bootstrap aren't layered properly when used with CSS from Bootstrap >= 3.3.0.
|
IMHO This is where SemVer comes in, react-bootstrap should try to stay with the current release of bootstrap and react. If users want backwards compatibility then they should use an older version, with the understanding that only bug fixes may or may not get published. I may note that although Bootstrap failed to bump the major version for a breaking change, that should not mean that we don't. |
|
Looks like this breaks the docs: Although this is not entirely your fault. I have another change I'd like to bring in, then I'll look at getting that css from npm (I just created #348 for that issue) |
|
Please be advised that Bootstrap v3.3.4 is going to move the backdrop back outside of the modal again; see twbs/bootstrap#15881 |
|
Thanks for the heads up. We'll keep an eye out for its release. |
|
Looks like 3.3.4 is out, I have tried it in my project with |
|
Wohoo ... darn So, with the latest changes I've been making it's really easy to try out the new version of bootstrap. Just All said it should be a quick upgrade so long as we figure out that docs css issue. |
In Bootstrap 3.3.0, the
.modal-backdropwas moved inside its corresponding.modal. See: twbs/bootstrap#14724With this, the
z-indexwas removed from the.modal-backdrop, meaning that modal backdrops in React Bootstrap aren't layered properly when used with CSS from Bootstrap >= 3.3.0.Note: this breaks Modals in Bootstrap < 3.3.0, because the backdrop winds up above the modal content.
What is React Bootstrap's policy for dealing with backwards-incompatible changes like this in Bootstrap itself? If you have a standard-ish way of handling this, I'm happy to update the PR accordingly!