fix: ran prettier to fix CI #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mxschmitt
commented
Apr 18, 2019
mxschmitt
commented
- Ran prettier to fix CI
- moved prettier Eslint rule into eslintrc file, so that it will be automatically recognized by Visual Studio Code e.g. and automatically fixed
This was referenced Apr 18, 2019
taion
reviewed
Apr 18, 2019
| ] | ||
| ], | ||
| "rules": { | ||
| "prettier/prettier": "error" |
There was a problem hiding this comment.
@jquense explicitly took this out earlier, which is why only ci-lint errors on this. do we want it back?
package.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| "build-docs": "yarn --cwd www run build", | |||
| "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s", | |||
| "start": "yarn --cwd www run develop", | |||
| "ci-lint": "eslint --rule \"prettier/prettier: 2\"", | |||
| "ci-lint": "eslint", | |||
There was a problem hiding this comment.
should drop this entirely and just use the normal eslint command if we're doing this
taion
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.