Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trade empty children option as leaf node #231

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 28, 2021

原本  children 为 空数组时,上游可以选择是个 bug。但是似乎 bug as feature 特别多。干脆 children 是空数组也当成 leaf 来处理保持一致性。

@vercel
Copy link

vercel bot commented Dec 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/cascader/4rkaidGmC5Xe8RXpS2wUEU9gYoF5
✅ Preview: https://cascader-git-fix-selection-react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #231 (23372fe) into master (6db62a5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          15       15           
  Lines         451      451           
  Branches      110      110           
=======================================
  Hits          450      450           
  Misses          1        1           
Impacted Files Coverage Δ
src/OptionList/index.tsx 100.00% <100.00%> (ø)
src/utils/commonUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db62a5...23372fe. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 28, 2021

This pull request fixes 1 alert when merging 23372fe into 6db62a5 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@zombieJ zombieJ merged commit fb0482b into master Dec 28, 2021
@zombieJ zombieJ deleted the fix-selection branch December 28, 2021 08:07
@zombieJ
Copy link
Member Author

zombieJ commented Dec 28, 2021

+ [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant