Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should support quotes in label and value #247

Merged
merged 8 commits into from
Feb 8, 2022
Merged

fix: should support quotes in label and value #247

merged 8 commits into from
Feb 8, 2022

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Feb 8, 2022

* fix: label should support "

* chore: code clean

* fix: LGTM test

* chore: code clean

* fix: LGTM

* chore: code clean
@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/cascader/FDYZUt3gC3Hfx4zvkEJzMocjv149
✅ Preview: https://cascader-git-fix-quotes-react-component.vercel.app

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #247 (2021de3) into master (199eb53) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          15       15           
  Lines         474      474           
  Branches      118      118           
=======================================
  Hits          473      473           
  Misses          1        1           
Impacted Files Coverage Δ
src/OptionList/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199eb53...2021de3. Read the comment docs.

@MadCcc MadCcc merged commit 775c280 into master Feb 8, 2022
@MadCcc MadCcc deleted the fix/quotes branch February 8, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant