feat: support optionRender #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 23 23
Lines 603 604 +1
Branches 173 174 +1
=======================================
+ Hits 601 602 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Mar 4, 2024
zombieJ
reviewed
Mar 4, 2024
zombieJ
reviewed
Mar 5, 2024
src/Cascader.tsx
Outdated
| @@ -74,6 +74,7 @@ interface BaseCascaderProps<OptionType extends BaseOptionType = DefaultOptionTyp | |||
| id?: string; | |||
| prefixCls?: string; | |||
| fieldNames?: FieldNames; | |||
| optionRender?: (oriOption: { option?: OptionType }) => React.ReactNode; | |||
There was a problem hiding this comment.
这个已经叫 oriOption 了，那传入参数就不需要再包一层 object 了
There was a problem hiding this comment.
以后加 index、level 呢？留着口子行吗
zombieJ
reviewed
Mar 6, 2024
zombieJ
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.