-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use father #197
chore: use father #197
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/dialog/ojgv7nz43 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@kermit-xuan,帮忙看看哈~~ |
麻烦邀请一下到项目 @zombieJ |
done |
这是点击没有关闭的原因, Line 188 in d9604fa
测试发现时间间隔在20多,肯定不能触发了,Mock一下就好了。 |
All done. @afc163 @zombieJ @kermit-xuan |
.eslintrc.js
Outdated
"jsx-a11y/label-has-for": 0, | ||
"jsx-a11y/label-has-associated-control": 0, | ||
"import/no-extraneous-dependencies": 0, | ||
"react/button-has-type": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个规则需要开一下,没有的地方补一补包括 example 的
typings/custom.d.ts
Outdated
@@ -1,14 +1,14 @@ | |||
declare module "rc-util/lib/KeyCode" { | |||
var Ret: {ESC:any;TAB:any;}; | |||
const Ret: {ESC:any;TAB:any;}; | |||
export default Ret; | |||
} | |||
|
|||
declare module "rc-util/lib/*" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rc-util 用到的应该都有 ts 定义了,不需要这个了~
export default Ret; | ||
} | ||
|
||
declare module "rc-animate" { | ||
var Ret: any; | ||
const Ret: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个合好后,看看有木有机会换成 rc-motion
~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
.eslintrc.js
Outdated
"@typescript-eslint/no-explicit-any": 0, | ||
"@typescript-eslint/no-empty-interface": 0, | ||
"@typescript-eslint/no-inferrable-types": 0, | ||
"react/no-find-dom-node": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好像没看到用到 findDOMNode 的地方,这个 rule 可以删了~
No description provided.