Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Callback #144

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Feat Callback #144

merged 2 commits into from
Apr 2, 2018

Conversation

benjycui
Copy link
Member

@benjycui benjycui commented Feb 9, 2018

@benjycui benjycui requested review from afc163 and warmhug February 9, 2018 04:39
@benjycui
Copy link
Member Author

benjycui commented Feb 9, 2018

@warmhug 这个 commit 看下 0598cdf

@warmhug
Copy link
Contributor

warmhug commented Feb 22, 2018

跟 RN 关系不大吧,需要 forceUpdate 后的 callback 的话、感觉这样做也可以的。

@benjycui
Copy link
Member Author

跟 RN 关系不大吧,需要 forceUpdate 后的 callback 的话、感觉这样做也可以的。

那个 commit 改了 RN 的 example 的 code style,但我不确定会不会把那个例子搞挂。

@warmhug
Copy link
Contributor

warmhug commented Feb 22, 2018

不会挂,没有破坏性改动

@chenshuai2144
Copy link
Contributor

最好改回来吧!
你完全没必要改代码风格

@benjycui
Copy link
Member Author

benjycui commented Feb 23, 2018

@chenshuai2144 code style 是 CI 的一部分,之前就应该改好才合并的。

@yesmeck
Copy link
Member

yesmeck commented Mar 2, 2018

Promise 不顺便支持下吗?

@benjycui
Copy link
Member Author

benjycui commented Mar 7, 2018

Promise 不顺便支持下吗?

其实不是很想让 rc-form 依赖 promise 。。。

@sylvainar
Copy link
Contributor

Will this be merged ? Seems that it solves some lint issues.

@benjycui benjycui merged commit 6bc6bcd into master Apr 2, 2018
@benjycui benjycui deleted the feat-callback branch April 2, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants