feat: add wrappedComponentRef and deprecate withRef #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjycui
commented
Jun 13, 2017
| // deprecated | ||
| const EnhancedForm = createForm({ withRef: true })(Form); | ||
| <EnhancedForm ref="form" /> | ||
| this.refs.form.refs.wrappedComponent // => The instance of Form |
There was a problem hiding this comment.
withRef 这种 API 使用起来麻烦，并且非常不稳定，因为依赖于组件层级。
benjycui
commented
Jun 13, 2017
| // Recommended | ||
| const EnhancedForm = createForm()(Form); | ||
| <EnhancedForm wrappedComponentRef={(inst) => this.formRef = inst} /> | ||
| this.formRef // => The instance of Form |
There was a problem hiding this comment.
wrappedComponentRef 直接指向我们希望暴露给用户的节点，使用方便，并且与组件层级无关，非常稳定。
There was a problem hiding this comment.
比如外层组件重置表单 this.formRef.props.form.resetFields()
There was a problem hiding this comment.
感觉是 anti-pattern ，外层组件如果有 reset 的行为，那么它应该包装成 rc-form 组件，然后把 props.form 传给内层表单 UI。
|
Changes Unknown when pulling edfe6c3 on feat-ref into ** on master**. |
yiminghe
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.