refactor: rename onDropdownScroll to onPopupScroll

react-component · Nov 26, 2024 · a00c7ac · a00c7ac
1 parent bc6f099
commit a00c7ac
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/docs/examples/onScroll.tsx b/docs/examples/onScroll.tsx
@@ -7,7 +7,7 @@ export default () => (
   <Mentions
     rows={3}
     defaultValue="Hello @ World @"
-    onDropdownScroll={console.log}
+    onPopupScroll={console.log}
     dropdownClassName="on-scroll"
     open
     options={Array.from({ length: 1000 }).map((_, index) => ({

diff --git a/src/Mentions.tsx b/src/Mentions.tsx
@@ -78,7 +78,7 @@ export interface MentionsProps extends BaseTextareaAttrs {
    * @param containerHeight The height of the mentions container
    * @param currentOffset The current scroll offset
    */
-  onDropdownScroll?: (
+  onPopupScroll?: (
     event: React.UIEvent<HTMLDivElement>,
     containerHeight: number,
     currentOffset: number,
@@ -141,7 +141,7 @@ const InternalMentions = forwardRef<MentionsRef, MentionsProps>(
       // https://github.com/ant-design/ant-design/blob/df933e94efc8f376003bbdc658d64b64a0e53495/components/mentions/demo/render-panel.tsx
       // @ts-expect-error
       visible,
-      onDropdownScroll,
+      onPopupScroll,
 
       // Rest
       ...restProps
@@ -473,7 +473,7 @@ const InternalMentions = forwardRef<MentionsRef, MentionsProps>(
       const containerHeight = currentTarget.getBoundingClientRect().height;
       const currentOffset = currentTarget.scrollTop;
 
-      onDropdownScroll?.(event, containerHeight, currentOffset);
+      onPopupScroll?.(event, containerHeight, currentOffset);
     };
 
     // ============================== Render ==============================

diff --git a/tests/Mentions.spec.tsx b/tests/Mentions.spec.tsx
@@ -300,15 +300,15 @@ describe('Mentions', () => {
     expect(container.firstChild).toHaveClass('rc-mentions-disabled');
   });
 
-  it('onDropdownScroll should work', () => {
-    const onDropdownScroll = jest.fn();
-    const { container, baseElement } = renderMentions({ onDropdownScroll });
+  it('onPopupScroll should work', () => {
+    const onPopupScroll = jest.fn();
+    const { container, baseElement } = renderMentions({ onPopupScroll });
     simulateInput(container, '@');
     act(() => {
       jest.runAllTimers();
     });
     fireEvent.scroll(baseElement.querySelector('.rc-mentions-dropdown-menu'));
-    expect(onDropdownScroll).toHaveBeenCalled();
+    expect(onPopupScroll).toHaveBeenCalled();
   });
 
   describe('nativeElement', () => {