fix: needConfirm false should not trigger open in SinglePicker (#914)

react-component · Feb 27, 2025 · 7bf946c · 7bf946c
1 parent 8a420c4
commit 7bf946c
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -1,4 +1,3 @@
 module.exports = {
-  setupFiles: ['./tests/setup.js'],
   coveragePathIgnorePatterns: ['src/locale/', 'tests/'],
 };
diff --git a/src/PickerInput/SinglePicker.tsx b/src/PickerInput/SinglePicker.tsx
@@ -603,7 +603,6 @@ function Picker<DateType extends object = any>(
 
     // Submit with complex picker
     if (!mergedOpen && complexPicker && !needConfirm && lastOp === 'panel') {
-      triggerOpen(true);
       triggerConfirm();
     }
   }, [mergedOpen]);

diff --git a/tests/new-range.spec.tsx b/tests/new-range.spec.tsx
@@ -785,6 +785,32 @@ describe('NewPicker.Range', () => {
       expect(container.querySelectorAll('input')[0]).toHaveValue('1990-09-05');
       expect(container.querySelectorAll('input')[1]).toHaveValue('1990-09-05');
     });
+
+    it('not trigger open when !needConfirm', () => {
+      const onChange = jest.fn();
+      const onOpenChange = jest.fn();
+
+      const { container } = render(
+        <DayPicker showTime onChange={onChange} onOpenChange={onOpenChange} needConfirm={false} />,
+      );
+      openPicker(container);
+
+      fireEvent.click(findCell(5));
+
+      act(() => {
+        jest.runAllTimers();
+      });
+      expect(onOpenChange).toHaveBeenCalledWith(true);
+
+      // Window click to close
+      fireEvent.mouseDown(document.body);
+      act(() => {
+        jest.runAllTimers();
+      });
+
+      expect(onOpenChange).toHaveBeenCalledTimes(2);
+      expect(onOpenChange).toHaveBeenCalledWith(false);
+    });
   });
 
   describe('open', () => {