Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dayjs locale mapping #382

Merged
merged 1 commit into from
Apr 13, 2022
Merged

update dayjs locale mapping #382

merged 1 commit into from
Apr 13, 2022

Conversation

iamkun
Copy link
Collaborator

@iamkun iamkun commented Apr 13, 2022

No description provided.

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/9k6XmbJUXezcd67gasYWgjFwZ3qa
✅ Preview: https://picker-git-feat-kun-react-component.vercel.app

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #382 (5eeedb3) into master (6123222) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          46       46           
  Lines        2148     2150    +2     
  Branches      633      635    +2     
=======================================
+ Hits         2138     2140    +2     
  Misses          8        8           
  Partials        2        2           
Impacted Files Coverage Δ
src/RangePicker.tsx 100.00% <100.00%> (ø)
src/generate/dayjs.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zombieJ zombieJ merged commit c19aed9 into master Apr 13, 2022
@zombieJ zombieJ deleted the feat/kun branch April 13, 2022 07:10
zh_CN: 'zh-cn',
zh_HK: 'zh-hk',
zh_TW: 'zh-tw',
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 map 是 moment 和 dayjs 的差异,还是不是可以在 dayjs 下单独长期维护一个。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 dayjs 和 antd locale 的差异 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但是后面也可以考虑 dayjs 自己做, moment 的 locale 命名和 dayjs 是一致的,但是在解析 locale string 的时候 moment 会把 zh_HK 解析成 zh-hk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants