Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize time selector panel step precision logic (#596) #617

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

Wxh16144
Copy link
Contributor

@Wxh16144 Wxh16144 commented Apr 12, 2023

Duplicate of #596


  • test: add case

  • chore: optimize time selector panel step precision logic

  • test: update snapshot

  • feat(type): update TS type

  • test: add case

  • fix: fix negative number error

  • perf: update performance

  • Update tests/picker.spec.tsx

Co-authored-by: MadCcc [email protected]


Co-authored-by: MadCcc [email protected]
(cherry picked from commit 9269984)

@vercel
Copy link

vercel bot commented Apr 12, 2023

@Wxh16144 is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@Wxh16144 Wxh16144 force-pushed the wuxh/fix-duplicate-596 branch from a76527a to b83ece4 Compare April 13, 2023 03:59
Wxh16144 and others added 5 commits April 14, 2023 10:19
…ent#596)

* test: add case

* chore: optimize time selector panel step precision logic

* test: update snapshot

* feat(type): update TS type

* test: add case

* fix: fix negative number error

* perf: update performance

* Update tests/picker.spec.tsx

Co-authored-by: MadCcc <[email protected]>

---------

Co-authored-by: MadCcc <[email protected]>
(cherry picked from commit 9269984)

# Conflicts:
#	src/interface.ts
#	tests/__snapshots__/picker.spec.tsx.snap
@Wxh16144 Wxh16144 force-pushed the wuxh/fix-duplicate-596 branch from b83ece4 to ccd04c3 Compare April 14, 2023 02:19
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #617 (de289fc) into 2.7.x (3cc178f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head de289fc differs from pull request most recent head ccd04c3. Consider uploading reports for the commit ccd04c3 to get more accurate results

@@           Coverage Diff           @@
##            2.7.x     #617   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          46       46           
  Lines        2160     2161    +1     
  Branches      643      644    +1     
=======================================
+ Hits         2144     2145    +1     
  Misses         14       14           
  Partials        2        2           
Impacted Files Coverage Δ
src/panels/TimePanel/TimeBody.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoyo837 yoyo837 merged commit a54ff72 into react-component:2.7.x Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants