fix: prevent picker blur when still in focus at 2.7.x #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luo3house is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
luo3house
commented
Apr 14, 2023
Comment on lines
+325
to
+333
| const mouseDownEvent = new MouseEvent('mousedown', { | ||
| view: window, | ||
| bubbles: true, | ||
| }); | ||
| Reflect.defineProperty(mouseDownEvent, 'target', { | ||
| value: wrapper.find('.suffix-icon').getDOMNode(), | ||
| enumerable: true, | ||
| }); | ||
| fireEvent(window, mouseDownEvent); |
There was a problem hiding this comment.
Seems enzyme renders elements independently. I retrieved null by document.querySelector(). Besides, fireEvents(wrapper.find().getDOMNode()) not work. So placed this workaround.
Codecov Report
@@ Coverage Diff @@
## 2.7.x #620 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 46 46
Lines 2160 2162 +2
Branches 643 644 +1
=======================================
+ Hits 2144 2146 +2
Misses 14 14
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yoyo837
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ant-design/ant-design#41608
ref #612