-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump trigger version #910
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Walkthrough本次 PR 主要针对依赖更新与导入路径调整。在 package.json 中,预发布脚本以及部分依赖项和开发依赖项被修改;多个组件、hook 和测试文件中的模块引用由旧的 Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
46-46
: 确认 rc-overflow 依赖的版本更新。
此处rc-overflow
版本标记为^1.3.2
。建议确认该版本更新是否符合项目整体依赖管理的版本策略,并确保不存在依赖冲突问题。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (33)
package.json
(2 hunks)src/PickerInput/Popup/index.tsx
(1 hunks)src/PickerInput/RangePicker.tsx
(1 hunks)src/PickerInput/Selector/Input.tsx
(1 hunks)src/PickerInput/Selector/RangeSelector.tsx
(1 hunks)src/PickerInput/Selector/hooks/useClearIcon.tsx
(1 hunks)src/PickerInput/Selector/hooks/useInputProps.ts
(6 hunks)src/PickerInput/SinglePicker.tsx
(1 hunks)src/PickerInput/hooks/useCellRender.ts
(2 hunks)src/PickerInput/hooks/useDelayState.ts
(2 hunks)src/PickerInput/hooks/useDisabledBoundary.ts
(1 hunks)src/PickerInput/hooks/useFilledProps.ts
(2 hunks)src/PickerInput/hooks/useInvalidate.ts
(3 hunks)src/PickerInput/hooks/useLockEffect.ts
(1 hunks)src/PickerInput/hooks/usePresets.ts
(2 hunks)src/PickerInput/hooks/useRangePickerValue.ts
(2 hunks)src/PickerInput/hooks/useRangeValue.ts
(3 hunks)src/PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx
(1 hunks)src/PickerPanel/TimePanel/TimePanelBody/useScrollTo.ts
(1 hunks)src/PickerPanel/index.tsx
(1 hunks)src/generate/moment.ts
(1 hunks)src/hooks/useTimeInfo.ts
(1 hunks)src/utils/warnUtil.ts
(1 hunks)tests/disabledTime.spec.tsx
(1 hunks)tests/keyboard.spec.tsx
(1 hunks)tests/loop.spec.tsx
(1 hunks)tests/multiple.spec.tsx
(1 hunks)tests/new-range.spec.tsx
(2 hunks)tests/panel.spec.tsx
(1 hunks)tests/picker.spec.tsx
(2 hunks)tests/range.spec.tsx
(1 hunks)tests/setup.js
(1 hunks)tests/time.spec.tsx
(1 hunks)
✅ Files skipped from review due to trivial changes (32)
- tests/keyboard.spec.tsx
- src/generate/moment.ts
- src/PickerInput/hooks/useCellRender.ts
- src/PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx
- src/PickerInput/Selector/Input.tsx
- tests/loop.spec.tsx
- src/PickerInput/Selector/hooks/useClearIcon.tsx
- src/utils/warnUtil.ts
- src/hooks/useTimeInfo.ts
- src/PickerInput/hooks/useFilledProps.ts
- tests/panel.spec.tsx
- src/PickerInput/SinglePicker.tsx
- src/PickerPanel/index.tsx
- src/PickerInput/Popup/index.tsx
- src/PickerInput/hooks/useRangePickerValue.ts
- src/PickerInput/hooks/useDisabledBoundary.ts
- src/PickerInput/hooks/useRangeValue.ts
- tests/time.spec.tsx
- src/PickerInput/Selector/RangeSelector.tsx
- src/PickerInput/hooks/useLockEffect.ts
- tests/multiple.spec.tsx
- src/PickerInput/hooks/useDelayState.ts
- src/PickerInput/hooks/useInvalidate.ts
- src/PickerInput/Selector/hooks/useInputProps.ts
- tests/setup.js
- src/PickerInput/hooks/usePresets.ts
- tests/disabledTime.spec.tsx
- src/PickerInput/RangePicker.tsx
- src/PickerPanel/TimePanel/TimePanelBody/useScrollTo.ts
- tests/range.spec.tsx
- tests/new-range.spec.tsx
- tests/picker.spec.tsx
🔇 Additional comments (3)
package.json (3)
32-32
: 更新 prepublishOnly 脚本为 rc-np。
将 prepublishOnly 脚本中调用的工具从 np 切换为 rc-np,符合依赖更新的要求。请确认 CI/CD 流程也相应更新,确保新工具正常工作。
42-44
: 新增和更新 @rc-component 相关依赖。
依次新增了@rc-component/resize-observer
和@rc-component/util
,同时将@rc-component/trigger
的版本从旧版更新为^3.0.0
。请检查项目中所有模块的引用,确保旧包的依赖已全部切换至新的@rc-component
包。
53-53
: 开发依赖中替换 np 为 @rc-component/np。
新的 devDependency@rc-component/np
替换了旧的np
,用于实现 prepublishOnly 脚本中的预发布任务。请检查项目中是否还有其他地方引用旧的np
,若有,请一并更新。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
- Coverage 98.71% 98.71% -0.01%
==========================================
Files 64 64
Lines 2652 2650 -2
Branches 736 730 -6
==========================================
- Hits 2618 2616 -2
Misses 31 31
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
Chores
Refactor
PickerTrigger
组件的弹出层过渡处理方式,采用对象配置替代字符串方式。Tests
此次更新主要为内部依赖和引用管理做了优化,用户使用体验保持不变,但为后续提升系统稳定性及功能扩展奠定了良好基础。