Skip to content

Commit

Permalink
Merge 573df4c into c91ecc4
Browse files Browse the repository at this point in the history
  • Loading branch information
yoyo837 authored Apr 20, 2023
2 parents c91ecc4 + 573df4c commit 1f84a97
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ Online examples: <https://react-component.github.io/tooltip/examples/>
</tr>
<tr>
<td>showArrow</td>
<td>boolean</td>
<td>boolean | { className?: string }</td>
<td>true</td>
<td>arrow visible</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
},
"dependencies": {
"@babel/runtime": "^7.11.2",
"@rc-component/trigger": "^1.0.4",
"@rc-component/trigger": "^1.10.0",
"classnames": "^2.3.1"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions src/Tooltip.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { TriggerProps, TriggerRef } from '@rc-component/trigger';
import type { TriggerProps, TriggerRef, ArrowType } from '@rc-component/trigger';
import Trigger from '@rc-component/trigger';
import type { ActionType, AlignType, AnimationType } from '@rc-component/trigger/lib/interface';
import * as React from 'react';
Expand Down Expand Up @@ -28,7 +28,7 @@ export interface TooltipProps extends Pick<TriggerProps, 'onPopupAlign' | 'built
getTooltipContainer?: (node: HTMLElement) => HTMLElement;
destroyTooltipOnHide?: boolean;
align?: AlignType;
showArrow?: boolean;
showArrow?: boolean | ArrowType;
arrowContent?: React.ReactNode;
id?: string;
children?: React.ReactElement;
Expand Down
19 changes: 18 additions & 1 deletion tests/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,26 @@ describe('rc-tooltip', () => {
</Tooltip>,
);
fireEvent.click(container.querySelector('.target'));
console.log(container.innerHTML);
expect(container.querySelector('.rc-tooltip-arrow')).toBeTruthy();
});
it('should show tooltip arrow when showArrow is object', () => {
const { container } = render(
<Tooltip
destroyTooltipOnHide
trigger={['click']}
placement="left"
overlay={<strong className="x-content">Tooltip content</strong>}
showArrow={{
className: 'abc'
}}
>
<div className="target">Click this</div>
</Tooltip>,
);
fireEvent.click(container.querySelector('.target'));
expect(container.querySelector('.rc-tooltip-arrow')).toBeTruthy();
expect(container.querySelector('.rc-tooltip-arrow').classList.contains('abc')).toBeTruthy();
});
it('should hide tooltip arrow when showArrow is false', () => {
const { container } = render(
<Tooltip
Expand Down

0 comments on commit 1f84a97

Please sign in to comment.