Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tooltip support show-arrow cls when showArrow not falsy #430

Merged
merged 5 commits into from
Jan 15, 2023
Merged

feat: tooltip support show-arrow cls when showArrow not falsy #430

merged 5 commits into from
Jan 15, 2023

Conversation

kiner-tang
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jan 14, 2023 •
edited
Loading

Codecov Report

Merging #430 (0cae988) into master (61a3286) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           34        35    +1     
  Branches        13        14    +1     
=========================================
+ Hits            34        35    +1
Impacted Files Coverage Δ
src/Tooltip.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zombieJ
zombieJ reviewed Jan 14, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
zombieJ
zombieJ reviewed Jan 14, 2023
View reviewed changes
src/Tooltip.tsx Outdated Show resolved Hide resolved
@kiner-tang kiner-tang requested a review from zombieJ January 14, 2023 06:33
@kiner-tang
Copy link
Contributor Author

@zombieJ 帮忙再看看

@zombieJ
Copy link
Member

zombieJ commented Jan 15, 2023

I'm OK with this. @MadCcc pls confirm

MadCcc
MadCcc reviewed Jan 15, 2023
View reviewed changes
src/Tooltip.tsx Outdated Show resolved Hide resolved
@kiner-tang kiner-tang requested a review from MadCcc January 15, 2023 12:50
@MadCcc MadCcc merged commit 187be03 into react-component:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ approved these changes

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiner-tang @zombieJ @MadCcc