Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async issue with scrollTo test #764

Merged

Conversation

mark-codylor
Copy link
Contributor

The implementation of rc-virtual-list has changed and is more async. Fixed the associated test by adding act. This is what they've done in the rc-virtual-list tests too:

https://github.com/react-component/virtual-list/blob/baf75273ba1f6106b87c635b9b951466537646d7/tests/scroll.test.js#L101

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tree ❌ Failed (Inspect) Oct 9, 2023 1:18am

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #764 (ce12ea6) into master (9269acc) will not change coverage.
The diff coverage is n/a.

❗ Current head ce12ea6 differs from pull request most recent head 72c2555. Consider uploading reports for the commit 72c2555 to get more accurate results

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          13       13           
  Lines        1261     1261           
  Branches      360      354    -6     
=======================================
  Hits         1257     1257           
  Misses          4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants