Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support mobile config #216

Merged
merged 7 commits into from
Nov 5, 2020
Merged

feat: Support mobile config #216

merged 7 commits into from
Nov 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 5, 2020

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #216 into master will increase coverage by 0.93%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   88.04%   88.97%   +0.93%     
==========================================
  Files          10       11       +1     
  Lines         485      517      +32     
  Branches      121      130       +9     
==========================================
+ Hits          427      460      +33     
+ Misses         58       57       -1     
Impacted Files Coverage Δ
src/Popup/MobilePopupInner.tsx 85.71% <85.71%> (ø)
src/Popup/PopupInner.tsx 96.42% <100.00%> (ø)
src/Popup/index.tsx 100.00% <100.00%> (ø)
src/index.tsx 85.07% <100.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8db52e...aaed695. Read the comment docs.

@zombieJ zombieJ changed the title [WIP] feat: Support mobile config feat: Support mobile config Nov 5, 2020
@zombieJ zombieJ merged commit cb4e2b3 into master Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the mobile branch November 5, 2020 09:04
popupVisible: boolean,
event?: { pageX: number; pageY: number },
) {
console.error('Change:::', popupVisible);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.error ?

@afc163
Copy link
Member

afc163 commented Nov 7, 2020

应该发个大版本。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants