Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: React state updated after component unmounted #240

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 19, 2021

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #240 (5bcc5df) into master (ec9ad5a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   89.01%   89.03%   +0.02%     
==========================================
  Files          11       11              
  Lines         519      520       +1     
  Branches      131      131              
==========================================
+ Hits          462      463       +1     
  Misses         57       57              
Impacted Files Coverage Δ
src/Popup/useVisibleStatus.ts 97.14% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9ad5a...27b3142. Read the comment docs.

@afc163 afc163 merged commit 9850be4 into master Feb 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-unmounted-state-update branch February 19, 2021 09:44
@zombieJ
Copy link
Member

zombieJ commented Feb 23, 2021

业务反馈 Table filter 遇到奇怪的现象,回退 rc-trigger 就好了。我瞅瞅是为啥……

Kapture 2021-02-23 at 14 21 37

@zombieJ
Copy link
Member

zombieJ commented Feb 23, 2021

setStatus(nextStatus);

align 状态是由外部异步更新,本身 effect 里不管 align 的 status 切换。cancel 后外部的状态更新请求被清理,导致状态锁在了 align 所以动画无法结束。我修一下。

rinick pushed a commit to rinick/trigger that referenced this pull request Mar 23, 2021
* fix: React state updated after component unmounted

close ant-design/ant-design#29328

* revert father version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants