fix: right click popup should be closed on mousedown target element #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 89.01% 89.11% +0.10%
==========================================
Files 11 11
Lines 528 533 +5
Branches 134 136 +2
==========================================
+ Hits 470 475 +5
Misses 58 58
Continue to review full report at Codecov.
|
zombieJ
reviewed
Apr 1, 2021
|
@rinick Can you link this PR to the issue it fixes by doing |
|
Seems contextMenu still not covered
|
I can't see that page, hope it's fixed this time |
|
@zombieJ ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue:
ant-design/ant-design#29853
I didn't check showAction or hideAction in isContextMenuOnly(), because when those 2 are defined, user might have very specific expectation about the mouse behavior, so I don't want to break existing code.