Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fresh #424

Merged
merged 3 commits into from
Sep 22, 2023
Merged

feat: add fresh #424

merged 3 commits into from
Sep 22, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 21, 2023

ref ant-design/ant-design#44830

添加 fresh 支持,默认情况下 trigger 关闭时会缓存内容保持稳定。但是在极少数情况下需要让内容保持更新。

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #424 (ea31a7f) into master (62826a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ea31a7f differs from pull request most recent head f48435e. Consider uploading reports for the commit f48435e to get more accurate results

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          13       13           
  Lines         787      788    +1     
  Branches      226      227    +1     
=======================================
+ Hits          769      770    +1     
  Misses         18       18           
Files Changed Coverage Δ
src/index.tsx 96.90% <ø> (ø)
src/Popup/index.tsx 93.44% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

popup={<strong className="x-content">{String(open)}</strong>}
action={['click']}
popupAlign={placementAlignMap.left}
fresh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldUpdate ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldUpdate 没有判断条件,这里只能是个 boolean

@zombieJ zombieJ merged commit 94fb671 into master Sep 22, 2023
@zombieJ zombieJ deleted the fix-nest branch September 22, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants