Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom request option #53

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Conversation

edgji
Copy link
Contributor

@edgji edgji commented Oct 9, 2016

I found myself needing to change portions of the AjaxUploader component to get it working with AWS S3. Allowing for the component to have a custom request prop would make extensibility easier.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.046% when pulling 7ffa0ca on edgji:custom-request into dbf0735 on react-component:master.

@shepherdwind
Copy link
Contributor

Thanks for you mr, but maybe you should add some document for how to use this option, thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.046% when pulling 744a778 on edgji:custom-request into dbf0735 on react-component:master.

@edgji
Copy link
Contributor Author

edgji commented Oct 12, 2016

I added some documentation for the proposed property. Should I add an example to the examples directory?

@shepherdwind shepherdwind merged commit fd3346f into react-component:master Oct 13, 2016
@shepherdwind
Copy link
Contributor

Thanks very much, example is not necessary.

2.2.0 published

@edgji edgji deleted the custom-request branch October 13, 2016 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants