Move TypeScript defs to own folder and add tests #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR for testing TS defs, as discussed in #244. It doesn't test them against the existing spec file -- between Karma augmenting the global namespace and the spec importing some Flow files, it ended up being a bit too tricky. Instead, this PR adds a
tests.tsx
file that simply verifies that the correct props are supported (as well as being optional.)(When microsoft/TypeScript#15160 lands it'll be possible to enforce that
Draggable
andDraggableCore
have a child as well.)I've also added invoking
tsc
to perform the checking as part of thetest
task inMakefile
.