Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Improve developer experience in React Native CLI ✨ #1820

Closed
szymonrybczak opened this issue Feb 6, 2023 · 5 comments
Closed

☂️ Improve developer experience in React Native CLI ✨ #1820

szymonrybczak opened this issue Feb 6, 2023 · 5 comments
Labels
discussion no-stale-bot This issue cannot be marked as stale by stale bot question Further information is requested

Comments

@szymonrybczak
Copy link
Collaborator

szymonrybczak commented Feb 6, 2023

Current stage

Currently there's ongoing effort to make React Native CLI better, and easier to use for developers. Recently these nice flags were created:

which allows users to select options in a nice and user-friendly way.

Next stage

While contributing and improving CLI, we're thinking about other improvements which can make CLI better. Here's list of improvements we would like to have in CLI in the nearest future:

@tido64
Copy link
Contributor

tido64 commented Feb 9, 2023

We recently discovered that pressing d in the terminal to open the dev menu only works on Android. It was introduced back in 0.47.0 (and in @react-native-community/cli 3.0.5-alpha.1) but only on Android. An iOS implementation is still missing today. Is this something that you can look into?

@szymonrybczak
Copy link
Collaborator Author

Hey @tido64, on CLI's side we're sending the devMenu socket, see here. I created PR facebook/react-native#36115 adding handling this websocket in react-native 😄

@TMisiukiewicz
Copy link
Collaborator

I already mentioned that somewhere, but if possible, i think it would be a nice DX improvement if the prompt from --list-devices was available also in --interactive mode. I can create an issue with more detailed description if you find this worth adding to the CLI

facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Feb 14, 2023
Summary:
Inspired by tido64's comment react-native-community/cli#1820 (comment) I'm adding missing implementation on iOS for invoking dev menu by pressing `d` in terminal while metro is launched.

## Changelog

[IOS][ADDED] - Add invoking dev menu on iOS by pressing `d` in terminal.

Pull Request resolved: #36115

Test Plan:
Press `d` in terminal while metro is launched - dev menu should appear.

https://user-images.githubusercontent.com/63900941/217936561-deea1390-221e-4f32-bbc4-e6fcfdf2a992.mp4

Reviewed By: rshest

Differential Revision: D43185001

Pulled By: javache

fbshipit-source-id: daa7af3b24b1b9f10d1a1ef8db8d9af816e912ea
@github-actions
Copy link

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label May 12, 2023
@thymikee thymikee removed the stale label May 14, 2023
@szymonrybczak szymonrybczak added the no-stale-bot This issue cannot be marked as stale by stale bot label May 15, 2023
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this issue May 22, 2023
…ook#36115)

Summary:
Inspired by tido64's comment react-native-community/cli#1820 (comment) I'm adding missing implementation on iOS for invoking dev menu by pressing `d` in terminal while metro is launched.

## Changelog

[IOS][ADDED] - Add invoking dev menu on iOS by pressing `d` in terminal.

Pull Request resolved: facebook#36115

Test Plan:
Press `d` in terminal while metro is launched - dev menu should appear.

https://user-images.githubusercontent.com/63900941/217936561-deea1390-221e-4f32-bbc4-e6fcfdf2a992.mp4

Reviewed By: rshest

Differential Revision: D43185001

Pulled By: javache

fbshipit-source-id: daa7af3b24b1b9f10d1a1ef8db8d9af816e912ea
@szymonrybczak
Copy link
Collaborator Author

Let's close this issue! If there are any other DevX improvements to CLI please report new issues! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion no-stale-bot This issue cannot be marked as stale by stale bot question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants