Remove unwanted spaces add_subdirectory paths in Android-rncli.cmake
#1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
add_subdirectory paths in Android-rncli.cmake
|
We miss the tests for this part unfortunately, so it's pretty manual at this point. |
thymikee
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes unwanted spaces in paths in
add_subdirectorycommand in autogeneratedAndroid-rncli.cmake:Along with #1734, this should fix building new-arch RN apps for Android on Windows.
Test Plan:
I couldn't find any snapshot tests that would contain
add_subdirectoryso not sure how to prove it works 🤷